From ee7a4d893f2c572395849ba24ff0d3dd9eab1553 Mon Sep 17 00:00:00 2001 From: helge Date: Sun, 2 Jan 2005 20:45:51 +0000 Subject: [PATCH] minor code cleanups git-svn-id: http://svn.opengroupware.org/SOPE/trunk@471 e4a50df8-12e2-0310-a44c-efbce7f8a7e3 --- sope-appserver/NGXmlRpc/ChangeLog | 4 ++++ sope-appserver/NGXmlRpc/Version | 2 +- .../NGXmlRpc/WODirectAction+XmlRpc.m | 19 ++++++++++++------- .../NGMimeRFC822DateHeaderFieldParser.m | 1 + 4 files changed, 18 insertions(+), 8 deletions(-) diff --git a/sope-appserver/NGXmlRpc/ChangeLog b/sope-appserver/NGXmlRpc/ChangeLog index d9374857..510ab1f9 100644 --- a/sope-appserver/NGXmlRpc/ChangeLog +++ b/sope-appserver/NGXmlRpc/ChangeLog @@ -1,3 +1,7 @@ +2005-01-02 Helge Hess + + * WODirectAction+XmlRpc.m: minor code cleanups (v4.5.9) + 2004-11-11 Marcus Mueller * NGXmlRpc.xcode: fixed a subtle bug that prevent Xcode from being diff --git a/sope-appserver/NGXmlRpc/Version b/sope-appserver/NGXmlRpc/Version index 46a90fec..f7255071 100644 --- a/sope-appserver/NGXmlRpc/Version +++ b/sope-appserver/NGXmlRpc/Version @@ -1,3 +1,3 @@ # version file -SUBMINOR_VERSION:=8 +SUBMINOR_VERSION:=9 diff --git a/sope-appserver/NGXmlRpc/WODirectAction+XmlRpc.m b/sope-appserver/NGXmlRpc/WODirectAction+XmlRpc.m index b1fecd1e..83ff3bdb 100644 --- a/sope-appserver/NGXmlRpc/WODirectAction+XmlRpc.m +++ b/sope-appserver/NGXmlRpc/WODirectAction+XmlRpc.m @@ -1,7 +1,7 @@ /* - Copyright (C) 2000-2003 SKYRIX Software AG + Copyright (C) 2000-2004 SKYRIX Software AG - This file is part of OGo + This file is part of OpenGroupware.org. OGo is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the @@ -18,7 +18,6 @@ Free Software Foundation, 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ -// $Id$ #include "WODirectAction+XmlRpc.h" #include @@ -32,10 +31,12 @@ static int CoreOnException = -1; - (NSString *)xmlrpcComponentNamespacePrefix { + // TODO: should be deprecated + NSUserDefaults *ud; NSString *np; - np = [[NSUserDefaults standardUserDefaults] - stringForKey:@"SxDefaultNamespacePrefix"]; + ud = [NSUserDefaults standardUserDefaults]; + np = [ud stringForKey:@"SxDefaultNamespacePrefix"]; if ([np length] > 0) return np; @@ -75,6 +76,7 @@ static int CoreOnException = -1; return @"com.skyrix"; } - (NSString *)xmlrpcComponentName { + // TODO: should be deprecated NSString *s; s = NSStringFromClass([self class]); @@ -85,6 +87,7 @@ static int CoreOnException = -1; } - (NSString *)xmlrpcComponentNamespace { + // TODO: should be deprecated NSString *ns, *n; ns = [self xmlrpcComponentNamespacePrefix]; @@ -259,14 +262,16 @@ static int CoreOnException = -1; cnt = (cnt > (int)[_params count]) ? (int)[_params count] : cnt; for (i = 0; i < cnt; i++) { - id param = [_params objectAtIndex:i]; + id param; + + param = [_params objectAtIndex:i]; [invo setArgument:¶m atIndex:(i + 2)]; } // TODO(hh): should fill the remaining args when less params available ? [invo invoke]; [invo getReturnValue:&result]; - + return result; } diff --git a/sope-mime/NGMime/NGMimeRFC822DateHeaderFieldParser.m b/sope-mime/NGMime/NGMimeRFC822DateHeaderFieldParser.m index 291a7269..47c2ec2e 100644 --- a/sope-mime/NGMime/NGMimeRFC822DateHeaderFieldParser.m +++ b/sope-mime/NGMime/NGMimeRFC822DateHeaderFieldParser.m @@ -451,6 +451,7 @@ static NSTimeZone *parseTimeZone(unsigned char *s, unsigned int len) { return date; failed: + // TODO: 'Sun, May 18 2003 14:20:55 -0700' - why does this fail? [self logWithFormat:@"WARNING: failed to parse RFC822 date field: '%@'", _data]; return nil; -- 2.39.5