From dd0d1654792158b848d01b4c0e14a38847b485ef Mon Sep 17 00:00:00 2001 From: LaMont Jones Date: Tue, 17 Jul 2007 22:43:15 -0600 Subject: [PATCH] logger: use snprintf instead of sprintf in logger.c Signed-off-by: LaMont Jones Signed-off-by: Karel Zak --- misc-utils/logger.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/misc-utils/logger.c b/misc-utils/logger.c index 5241a193..9a7cb058 100644 --- a/misc-utils/logger.c +++ b/misc-utils/logger.c @@ -89,9 +89,8 @@ mysyslog(int fd, int logflags, int pri, char *tag, char *msg) { time_t now; if (fd > -1) { - /* avoid snprintf - it does not exist on ancient systems */ if (logflags & LOG_PID) - sprintf (pid, "[%d]", getpid()); + snprintf (pid, sizeof(pid), "[%d]", getpid()); else pid[0] = 0; if (tag) @@ -104,8 +103,7 @@ mysyslog(int fd, int logflags, int pri, char *tag, char *msg) { (void)time(&now); tp = ctime(&now)+4; - /* do snprintf by hand - ugly, but for once... */ - sprintf(buf, "<%d>%.15s %.200s%s: %.400s", + snprintf(buf, sizeof(buf), "<%d>%.15s %.200s%s: %.400s", pri, tp, cp, pid, msg); if (write(fd, buf, strlen(buf)+1) < 0) -- 2.39.5