From d725fdc8027a4cd961f58d92917fbb91b171abfa Mon Sep 17 00:00:00 2001 From: Oleg Nesterov Date: Fri, 10 Aug 2007 15:21:17 -0700 Subject: [PATCH] [DCCP]: fix theoretical ccids_{read,write}_lock() race Make sure that spin_unlock_wait() is properly ordered wrt atomic_inc(). (akpm: can't we convert this code to use rwlocks?) Signed-off-by: Oleg Nesterov Signed-off-by: Andrew Morton Signed-off-by: David S. Miller --- net/dccp/ccid.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/dccp/ccid.c b/net/dccp/ccid.c index ccbf72c793..c45088b5e6 100644 --- a/net/dccp/ccid.c +++ b/net/dccp/ccid.c @@ -40,6 +40,7 @@ static inline void ccids_write_unlock(void) static inline void ccids_read_lock(void) { atomic_inc(&ccids_lockct); + smp_mb__after_atomic_inc(); spin_unlock_wait(&ccids_lock); } -- 2.39.5