From cd5ebb61835ac6558de3f9be99705515d1802aaf Mon Sep 17 00:00:00 2001
From: helge <helge@e4a50df8-12e2-0310-a44c-efbce7f8a7e3>
Date: Wed, 1 Jun 2005 21:12:10 +0000
Subject: [PATCH] added some comments, subminor tweaks

git-svn-id: http://svn.opengroupware.org/SOPE/trunk@817 e4a50df8-12e2-0310-a44c-efbce7f8a7e3
---
 sope-gdl1/GDLAccess/EOExpressionArray.h | 17 ++++++++++++++++-
 sope-gdl1/GDLAccess/EOSQLExpression.h   | 17 +++++++++++------
 sope-gdl1/GDLAccess/EOSQLQualifier.h    |  8 ++++++++
 3 files changed, 35 insertions(+), 7 deletions(-)

diff --git a/sope-gdl1/GDLAccess/EOExpressionArray.h b/sope-gdl1/GDLAccess/EOExpressionArray.h
index 4452d866..24d586f8 100644
--- a/sope-gdl1/GDLAccess/EOExpressionArray.h
+++ b/sope-gdl1/GDLAccess/EOExpressionArray.h
@@ -38,6 +38,21 @@
 
 @end
 
+/*
+  Notes
+  
+  In LSExtendedSearchCommand this is bound to the 'content' of EOSQLQualifier
+  and contains an array like:
+
+    "(", "(", "(", LOWER, "(", { allowsNull=Y; columnName=name; width=50;...},
+    ...
+    " = ", 0, ")", ")"
+
+  so it seems to be a stream of tokens and an EOAttribute mixed in for column
+  keys.
+  
+  Apparently only EOSQLExpression supports the 'EOExpressionContext'?
+*/
 
 @interface EOExpressionArray : NSObject < NSMutableCopying >
 {
@@ -93,7 +108,7 @@
 
 
 @interface NSObject (EOExpression)
-- (NSString*)expressionValueForContext:(id<EOExpressionContext>)context;
+- (NSString *)expressionValueForContext:(id<EOExpressionContext>)context;
 @end
 
 #endif /* __EOExpressionArray_h__ */
diff --git a/sope-gdl1/GDLAccess/EOSQLExpression.h b/sope-gdl1/GDLAccess/EOSQLExpression.h
index 5c91e2de..d4b51576 100644
--- a/sope-gdl1/GDLAccess/EOSQLExpression.h
+++ b/sope-gdl1/GDLAccess/EOSQLExpression.h
@@ -30,13 +30,18 @@
 #import <Foundation/NSDictionary.h>
 #import <Foundation/NSArray.h>
 
-#import <GDLAccess/EOExpressionArray.h>
-#import <GDLAccess/EOJoinTypes.h>
+#include <GDLAccess/EOExpressionArray.h>
+#include <GDLAccess/EOJoinTypes.h>
 
-@class EOAdaptor;
-@class EOAdaptorChannel;
-@class EOEntity;
-@class EOSQLQualifier;
+/*
+  EOSQLExpression
+
+  TODO: document
+  
+  Apparently the only object which implements EOExpressionContext?
+*/
+
+@class EOAdaptor, EOAdaptorChannel, EOEntity, EOSQLQualifier;
 
 extern NSString *EOBindVariableNameKey;
 extern NSString *EOBindVariablePlaceHolderKey;
diff --git a/sope-gdl1/GDLAccess/EOSQLQualifier.h b/sope-gdl1/GDLAccess/EOSQLQualifier.h
index 8528f650..7a546df0 100644
--- a/sope-gdl1/GDLAccess/EOSQLQualifier.h
+++ b/sope-gdl1/GDLAccess/EOSQLQualifier.h
@@ -33,6 +33,14 @@
 
 #import <GDLAccess/EOExpressionArray.h>
 
+/*
+  EOSQLQualifier
+  
+  TODO: document
+
+  Note: the expression context is the EOSQLExpression.
+*/
+
 @class NSDictionary, NSString, NSMutableSet;
 @class EOEntity, EORelationship, EOExpressionArray, EOSQLQualifier;
 @class EOSQLExpression;
-- 
2.39.5