From cbf0d27a131639f4f3e4faa94373c5c6f89f8f07 Mon Sep 17 00:00:00 2001 From: Mark Fasheh Date: Tue, 6 Sep 2005 15:19:08 -0700 Subject: [PATCH] [PATCH] kjournald: missing JFS_UNMOUNT check It seems that kjournald() may be missing a check of the JFS_UNMOUNT flag before calling schedule(). This showed up in testing of OCFS2 recovery where our recovery thread would hang in journal_kill_thread() called from journal_destroy() because kjournald never got a chance to read the flag to shut down before the schedule(). Zach pointed out the missing check which led me to hack up this trivial patch. It's been tested many times now and I have yet to reproduce the hang, which was happening very regularly before. I'm guessing that we could really use some wait_event() calls with helper functions in, well, most of jbd these days which would make a ton of the wait code there vastly cleaner. As for why this doesn't happen in ext3 (or OCFS2 during normal mount/unmount of the local nodes journal), I think it may that the specific timing of events in the ocfs2 recovery thread exposes a race there. Because ocfs2_replay_journal() is only interested in playing back the journal, initialization and shutdown happen very quicky with no other metadata put into that specific journal. Acked-by: "Stephen C. Tweedie" Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- fs/jbd/journal.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c index 71cfe25d71..334f4cf082 100644 --- a/fs/jbd/journal.c +++ b/fs/jbd/journal.c @@ -179,6 +179,8 @@ loop: if (transaction && time_after_eq(jiffies, transaction->t_expires)) should_sleep = 0; + if (journal->j_flags & JFS_UNMOUNT) + should_sleep = 0; if (should_sleep) { spin_unlock(&journal->j_state_lock); schedule(); -- 2.39.5