From c32e0c40f7e706e3ebcd101187d5ced96f083491 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Tue, 18 Jan 2011 23:51:06 +0100 Subject: [PATCH] serial-getty: invoking /sbin/securetty is no longer necessary since pam_securetty can now look for console= in /proc/cmdline --- TODO | 60 ++++++++++++++++------------------ units/serial-getty@.service.m4 | 3 -- 2 files changed, 28 insertions(+), 35 deletions(-) diff --git a/TODO b/TODO index ace7465c..65aebb5c 100644 --- a/TODO +++ b/TODO @@ -1,42 +1,55 @@ -* reload PID file after reload, allow dynamically changing main PIDs +Bugs: * Fix multiple reload statements +* sometimes processes seem to remain when we kill a service + http://lists.fedoraproject.org/pipermail/devel/2011-January/147559.html + +* dep loop when using encrypted swap + https://bugzilla.redhat.com/show_bug.cgi?id=657234 + +* somehow some /etc/fstab supplied mount params are never applied to api fs + https://bugzilla.redhat.com/show_bug.cgi?id=663108 + +* automount units can cause a segfault: + https://bugs.freedesktop.org/show_bug.cgi?id=32076 + +* bind mounts with 'fsck' fail and block for a minute: + /foo /bar none bind 1 1 + (requesting fsck is wrong, but why do we block for a minute + instead of just handling the error) + +* isolate multi-user.target doesn't start a getty@tty1 if we run it from graphical.target + +* sendmail.service doesn't get rid PID file, fails to kill everything on stop + +Features: + +* maybe introduce ExecRestartPre= + +* reload PID file after reload, allow dynamically changing main PIDs + * figure out what happened to bluez patch * introduce StandardOutput=syslog+console and StandardOutput=kmsg+console to support fsck output at boot * Patch systemd-fsck to use -C and pass console fd to it -* sometimes processes seem to remain when we kill a service - http://lists.fedoraproject.org/pipermail/devel/2011-January/147559.html - * support remote/ssh systemctl/systemadm, and local privileged access * finish syslog socket stuff * configurable jitter for timer events -* dbus should run with oom adjust set - * support caching password questions in plymouth and on the console https://bugzilla.redhat.com/show_bug.cgi?id=655538 -* dep loop when using encrypted swap - https://bugzilla.redhat.com/show_bug.cgi?id=657234 - * exclude java hsp files by default https://bugzilla.redhat.com/show_bug.cgi?id=527425 * load EnvironmentFile= when starting services, not when reloading configuration https://bugzilla.redhat.com/show_bug.cgi?id=661282 -* somehow some /etc/fstab supplied mount params are never applied to api fs - https://bugzilla.redhat.com/show_bug.cgi?id=663108 - -* automount units can cause a segfault: - https://bugs.freedesktop.org/show_bug.cgi?id=32076 - * support globs in systemd-tmpfiles * drop IN_ATTRIB from inotify watches for .path units where possible to avoid @@ -48,11 +61,6 @@ * Integrate "mdadm --wait-clean". Maybe just let SIGTERM to mdmon trigger the needed action -* bind mounts with 'fsck' fail and block for a minute: - /foo /bar none bind 1 1 - (requesting fsck is wrong, but why do we block for a minute - instead of just handling the error) - * oneshot services which do not remain: 'exited' instead of 'dead'? it should be visible in 'systemctl' that they have been run? @@ -126,20 +134,10 @@ http://git.kernel.org/?p=linux/kernel/git/gregkh/tty-2.6.git;a=commitdiff;h=fbc92a3455577ab17615cbcb91826399061bd789 http://git.kernel.org/?p=linux/kernel/git/gregkh/tty-2.6.git;a=commitdiff;h=b7b8de087384cc1954a8cd075af3f9e5977caa2e -* fix hotplug transactions - -* isolate multi-user.target doesn't start a getty@tty1 if we run it from graphical.target - -* sendmail.service doesn't get rid PID file, fails to kill everything on stop - * global defaults for StandardOuput=xxx -* mkswap/mke2fs is called on wrong devices in crypto devices. - Fedora: -* obsolete readhead in systemd pkg - * chkconfig → systemd enable/daemon-reload glue * /var/lock, /var/run → what happens if rpm stuff is no %ghosted? @@ -155,8 +153,6 @@ External: * place /etc/inittab with explaining blurb. -* pam_securetty should honour console= - * procps, psmisc, sysvinit-tools, hostname → util-linux-ng https://bugzilla.redhat.com/show_bug.cgi?id=614245 -- plymouth diff --git a/units/serial-getty@.service.m4 b/units/serial-getty@.service.m4 index b3bc37ed..c7a11b1f 100644 --- a/units/serial-getty@.service.m4 +++ b/units/serial-getty@.service.m4 @@ -23,9 +23,6 @@ Before=getty.target [Service] Environment=TERM=vt100 -m4_ifdef(`TARGET_FEDORA', -ExecStartPre=-/sbin/securetty %I -)m4_dnl ExecStart=-/sbin/agetty -s %I 115200,38400,9600 Restart=always RestartSec=0 -- 2.39.5