From b9d88fe3b4cf7abd62faeee186ab398be9c91f9b Mon Sep 17 00:00:00 2001
From: znek <znek@d1b88da0-ebda-0310-925b-ed51d893ca5b>
Date: Fri, 13 Aug 2004 16:15:37 +0000
Subject: [PATCH] adjust display to more closely meet requirements specs.

git-svn-id: http://svn.opengroupware.org/SOGo/trunk@204 d1b88da0-ebda-0310-925b-ed51d893ca5b
---
 SOGo/UI/Scheduler/ChangeLog                 | 11 +++++
 SOGo/UI/Scheduler/UIxCalDayChartview.wox    |  4 +-
 SOGo/UI/Scheduler/UIxCalDayListview.wox     |  4 +-
 SOGo/UI/Scheduler/UIxCalDayOverview.wox     |  8 +++-
 SOGo/UI/Scheduler/UIxCalDayPrintview.wox    |  8 +++-
 SOGo/UI/Scheduler/UIxCalDayView.m           | 37 ----------------
 SOGo/UI/Scheduler/UIxCalMonthOverview.wox   |  8 +++-
 SOGo/UI/Scheduler/UIxCalView.m              | 48 ++++++++++++++++-----
 SOGo/UI/Scheduler/UIxCalWeekChartview.wox   |  8 +++-
 SOGo/UI/Scheduler/UIxCalWeekColumnsview.wox |  8 +++-
 SOGo/UI/Scheduler/UIxCalWeekListview.wox    |  8 +++-
 SOGo/UI/Scheduler/UIxCalWeekOverview.wox    |  8 +++-
 SOGo/UI/Scheduler/Version                   |  2 +-
 13 files changed, 98 insertions(+), 64 deletions(-)

diff --git a/SOGo/UI/Scheduler/ChangeLog b/SOGo/UI/Scheduler/ChangeLog
index d9c8dcd6..ffdd4dee 100644
--- a/SOGo/UI/Scheduler/ChangeLog
+++ b/SOGo/UI/Scheduler/ChangeLog
@@ -1,3 +1,14 @@
+2004-08-13  Marcus Mueller  <znek@mulle-kybernetik.com>
+
+	* v0.9.33
+
+	* UIxCalView.m: adjusted shortTextForApt to meet the requirements
+	  specifictions.
+
+	* UIxCalDayView.m: removed shortTextForApt (moved to superclass).
+
+	* UIxCal*view.wox: escapeHTML="NO" for shortTextForApt.
+
 2004-08-13  Marcus Mueller  <znek@mulle-kybernetik.com>
 
 	* v0.9.32
diff --git a/SOGo/UI/Scheduler/UIxCalDayChartview.wox b/SOGo/UI/Scheduler/UIxCalDayChartview.wox
index a5b204af..887e05d2 100644
--- a/SOGo/UI/Scheduler/UIxCalDayChartview.wox
+++ b/SOGo/UI/Scheduler/UIxCalDayChartview.wox
@@ -212,7 +212,9 @@
                               <a var:href="appointmentViewURL"
                                  var:queryDictionary="currentDateQueryParameters"
                                  var:title="tooltipForApt"
-                              ><var:string value="shortTextForApt" /></a>
+                              ><var:string value="shortTextForApt"
+                                           const:escapeHTML="NO"
+                                /></a>
                             </var:matrix-cell>
                           </var:vspan-matrix>
                         </td>
diff --git a/SOGo/UI/Scheduler/UIxCalDayListview.wox b/SOGo/UI/Scheduler/UIxCalDayListview.wox
index 64b491fa..e3903587 100644
--- a/SOGo/UI/Scheduler/UIxCalDayListview.wox
+++ b/SOGo/UI/Scheduler/UIxCalDayListview.wox
@@ -167,7 +167,9 @@
                               <var:foreach list="aptsForCurrentDate" item="appointment">
                                 <a var:href="appointmentViewURL"
                                    var:queryDictionary="currentDateQueryParameters"
-                                ><var:string value="shortTextForApt" /></a>
+                                ><var:string value="shortTextForApt"
+                                             const:escapeHTML="NO"
+                                 /></a>
                                 <br />
                               </var:foreach>
                             </td>
diff --git a/SOGo/UI/Scheduler/UIxCalDayOverview.wox b/SOGo/UI/Scheduler/UIxCalDayOverview.wox
index 0066b9cf..cd1d0c23 100644
--- a/SOGo/UI/Scheduler/UIxCalDayOverview.wox
+++ b/SOGo/UI/Scheduler/UIxCalDayOverview.wox
@@ -167,7 +167,9 @@
                                 <a var:href="appointmentViewURL"
                                    var:queryDictionary="currentDateQueryParameters"
                                    var:title="tooltipForApt"
-                                ><var:string value="shortTextForApt" /></a>
+                                ><var:string value="shortTextForApt"
+                                             const:escapeHTML="NO"
+                                 /></a>
                                 <br />
                               </var:foreach>
                             </td>
@@ -191,7 +193,9 @@
                                 <a var:href="appointmentViewURL"
                                    var:queryDictionary="currentDateQueryParameters"
                                    var:title="tooltipForApt"
-                                ><var:string value="shortTextForApt" /></a>
+                                ><var:string value="shortTextForApt"
+                                             const:escapeHTML="NO"
+                                 /></a>
                                 <br />
                               </var:foreach>
                             </td>
diff --git a/SOGo/UI/Scheduler/UIxCalDayPrintview.wox b/SOGo/UI/Scheduler/UIxCalDayPrintview.wox
index 646d0299..c6b5533e 100644
--- a/SOGo/UI/Scheduler/UIxCalDayPrintview.wox
+++ b/SOGo/UI/Scheduler/UIxCalDayPrintview.wox
@@ -30,7 +30,9 @@
           </td>
           <td class="dayprintview_content">
             <var:foreach list="allDayApts" item="appointment">
-              <var:string value="shortTextForApt" />
+              <var:string value="shortTextForApt"
+                          const:escapeHTML="NO"
+              />
               <br />
             </var:foreach>
           </td>
@@ -45,7 +47,9 @@
           </td>
           <var:foreach list="aptsForCurrentDate" item="appointment">
             <td class="dayprintview_content">
-              <var:string value="shortTextForApt" />
+              <var:string value="shortTextForApt"
+                          const:escapeHTML="NO"
+              />
             </td>
             <var:if condition="minRequiredRowSpan" const:value="1" const:negate="YES">
             </var:if>
diff --git a/SOGo/UI/Scheduler/UIxCalDayView.m b/SOGo/UI/Scheduler/UIxCalDayView.m
index 5c3d14c6..7d7c734a 100644
--- a/SOGo/UI/Scheduler/UIxCalDayView.m
+++ b/SOGo/UI/Scheduler/UIxCalDayView.m
@@ -117,43 +117,6 @@
 }
 
 
-- (NSString *)shortTextForApt {
-    NSCalendarDate *startDate, *endDate;
-    NSMutableString *aptDescr;
-    NSString *s;
-    BOOL spansRange;
-    id apt;
-    
-    apt = [self appointment];
-    spansRange = NO;
-    startDate = [apt valueForKey:@"startDate"];
-    [startDate setTimeZone:[self viewTimeZone]];
-    endDate = [apt valueForKey:@"endDate"];
-    if(endDate != nil) {
-        [endDate setTimeZone:[self viewTimeZone]];
-        spansRange = ![endDate isEqualToDate:startDate];
-    }
-    aptDescr = [[NSMutableString alloc] init];
-    [aptDescr appendFormat:@"%02i:%02i",
-        [startDate hourOfDay],
-        [startDate minuteOfHour]];
-    if(spansRange) {
-        [aptDescr appendFormat:@"- %02i:%02i",
-            [endDate hourOfDay],
-            [endDate minuteOfHour]];
-    }
-    s = [apt valueForKey:@"title"];
-    if(s) {
-        [aptDescr appendFormat:@"; %@", s];
-    }
-    s = [apt valueForKey:@"location"];
-    if(s) {
-        [aptDescr appendFormat:@"; %@", s];
-    }
-    return [aptDescr autorelease];
-}
-
-
 /* URLs */
 
 - (NSDictionary *)prevDayQueryParameters {
diff --git a/SOGo/UI/Scheduler/UIxCalMonthOverview.wox b/SOGo/UI/Scheduler/UIxCalMonthOverview.wox
index 3391cad7..a8064aaf 100644
--- a/SOGo/UI/Scheduler/UIxCalMonthOverview.wox
+++ b/SOGo/UI/Scheduler/UIxCalMonthOverview.wox
@@ -112,7 +112,9 @@
                     </var:if>
                     <var:foreach list="allDayApts" item="appointment">
                       <a var:href="appointmentViewURL"
-                      ><var:string value="shortTextForApt"/></a>
+                      ><var:string value="shortTextForApt"
+                                   const:escapeHTML="NO"
+                       /></a>
                       <br />
                     </var:foreach>
                   </var:month-info>
@@ -148,7 +150,9 @@
                        class="monthoverview_content_link"
                        var:title="tooltipForApt"
                        var:queryDictionary="currentDayQueryParameters"
-                    ><var:string value="shortTitleForApt"/></a>
+                    ><var:string value="shortTextForApt"
+                                 const:escapeHTML="NO"
+                     /></a>
                     <br />
                   </var:month>
                 </var:month-overview>
diff --git a/SOGo/UI/Scheduler/UIxCalView.m b/SOGo/UI/Scheduler/UIxCalView.m
index 9405d2e9..b08b88cc 100644
--- a/SOGo/UI/Scheduler/UIxCalView.m
+++ b/SOGo/UI/Scheduler/UIxCalView.m
@@ -57,16 +57,44 @@ static BOOL shouldDisplayWeekend = NO;
 }
 
 - (NSString *)shortTextForApt {
-  NSCalendarDate *startDate;
-  NSString *ms;
-  
-  startDate = [[self appointment] valueForKey:@"startDate"];
-  [startDate setTimeZone:[self viewTimeZone]];
-  ms = [NSString stringWithFormat:@"%02i:%02i %@",
-		 [startDate hourOfDay],
-		 [startDate minuteOfHour],
-		 [[self appointment] valueForKey:@"title"]];
-  return ms;
+    NSCalendarDate *startDate, *endDate;
+    NSMutableString *aptDescr;
+    NSString *s;
+    BOOL spansRange;
+    id apt;
+    
+    apt = [self appointment];
+    spansRange = NO;
+    startDate = [apt valueForKey:@"startDate"];
+    [startDate setTimeZone:[self viewTimeZone]];
+    endDate = [apt valueForKey:@"endDate"];
+    if(endDate != nil) {
+        [endDate setTimeZone:[self viewTimeZone]];
+        spansRange = ![endDate isEqualToDate:startDate];
+    }
+    aptDescr = [[NSMutableString alloc] init];
+    [aptDescr appendFormat:@"%02i:%02i",
+        [startDate hourOfDay],
+        [startDate minuteOfHour]];
+    if(spansRange) {
+        [aptDescr appendFormat:@", %02i:%02i",
+            [endDate hourOfDay],
+            [endDate minuteOfHour]];
+    }
+    s = [apt valueForKey:@"location"];
+    if(s) {
+        if([s length] > 12) {
+            s = [NSString stringWithFormat:@"%@...",
+                [s substringToIndex:11]];
+        }
+        [aptDescr appendFormat:@" (%@)", s];
+    }
+    s = [apt valueForKey:@"title"];
+    if(s) {
+        [aptDescr appendFormat:@"<br />%@",
+            [self shortTitleForApt]];
+    }
+    return [aptDescr autorelease];
 }
 
 - (NSString *)shortTitleForApt {
diff --git a/SOGo/UI/Scheduler/UIxCalWeekChartview.wox b/SOGo/UI/Scheduler/UIxCalWeekChartview.wox
index 8ad53360..0fefb3f3 100644
--- a/SOGo/UI/Scheduler/UIxCalWeekChartview.wox
+++ b/SOGo/UI/Scheduler/UIxCalWeekChartview.wox
@@ -158,13 +158,17 @@
           <var:foreach list="allDayApts" item="appointment">
             <a var:href="appointmentViewURL"
                var:queryDictionary="currentDayQueryParameters"
-              ><var:string value="shortTextForApt" /></a>
+              ><var:string value="shortTextForApt"
+                           const:escapeHTML="NO"
+               /></a>
           </var:foreach>
         </var:week-info>
       </var:if>
       <var:week>
         <a var:href="appointmentViewURL" 
-          ><small><var:string value="shortTextForApt" /></small></a><br />
+          ><small><var:string value="shortTextForApt"
+                              const:escapeHTML="NO"
+                  /></small></a><br />
       </var:week>
     </var:week-overview>
   </var:component>
diff --git a/SOGo/UI/Scheduler/UIxCalWeekColumnsview.wox b/SOGo/UI/Scheduler/UIxCalWeekColumnsview.wox
index 4eda8c98..f76ace16 100644
--- a/SOGo/UI/Scheduler/UIxCalWeekColumnsview.wox
+++ b/SOGo/UI/Scheduler/UIxCalWeekColumnsview.wox
@@ -207,13 +207,17 @@
                     <var:foreach list="allDayApts" item="appointment">
                       <a var:href="appointmentViewURL"
                          var:queryDictionary="currentDayQueryParameters"
-                        ><var:string value="shortTextForApt" /></a>
+                        ><var:string value="shortTextForApt"
+                                     const:escapeHTML="NO"
+                         /></a>
                     </var:foreach>
                   </var:weekcol-info>
                 </var:if>
                 <var:weekcol>
                   <a var:href="appointmentViewURL" 
-                    ><small><var:string value="shortTextForApt" /></small></a><br />
+                    ><small><var:string value="shortTextForApt"
+                                        const:escapeHTML="NO"
+                            /></small></a><br />
                 </var:weekcol>
               </var:weekcol-view>
             </td>
diff --git a/SOGo/UI/Scheduler/UIxCalWeekListview.wox b/SOGo/UI/Scheduler/UIxCalWeekListview.wox
index 7f19a5df..14dbb754 100644
--- a/SOGo/UI/Scheduler/UIxCalWeekListview.wox
+++ b/SOGo/UI/Scheduler/UIxCalWeekListview.wox
@@ -161,13 +161,17 @@
           <var:foreach list="allDayApts" item="appointment">
             <a var:href="appointmentViewURL"
                var:queryDictionary="currentDayQueryParameters"
-              ><var:string value="shortTextForApt" /></a>
+              ><var:string value="shortTextForApt"
+                           const:escapeHTML="NO"
+               /></a>
           </var:foreach>
         </var:week-info>
       </var:if>
       <var:week>
         <a var:href="appointmentViewURL" 
-          ><small><var:string value="shortTextForApt" /></small></a><br />
+          ><small><var:string value="shortTextForApt"
+                              const:escapeHTML="NO"
+                  /></small></a><br />
       </var:week>
     </var:week-overview>
   </var:component>
diff --git a/SOGo/UI/Scheduler/UIxCalWeekOverview.wox b/SOGo/UI/Scheduler/UIxCalWeekOverview.wox
index 87aceebf..a00b2357 100644
--- a/SOGo/UI/Scheduler/UIxCalWeekOverview.wox
+++ b/SOGo/UI/Scheduler/UIxCalWeekOverview.wox
@@ -165,14 +165,18 @@
           <var:foreach list="allDayApts" item="appointment">
             <a var:href="appointmentViewURL"
                var:queryDictionary="currentDayQueryParameters"
-              ><var:string value="shortTextForApt" /></a>
+            ><var:string value="shortTextForApt"
+                         const:escapeHTML="NO"
+             /></a>
           </var:foreach>
         </var:week-info>
       </var:if>
       <var:week>
         <a var:href="appointmentViewURL" 
            var:title="tooltipForApt"
-          ><small><var:string value="shortTextForApt" /></small></a><br />
+          ><small><var:string value="shortTextForApt"
+                              const:escapeHTML="NO"
+                  /></small></a><br />
       </var:week>
     </var:week-overview>
   </var:component>
diff --git a/SOGo/UI/Scheduler/Version b/SOGo/UI/Scheduler/Version
index cf4bca34..8c14e0bf 100644
--- a/SOGo/UI/Scheduler/Version
+++ b/SOGo/UI/Scheduler/Version
@@ -1,6 +1,6 @@
 # $Id$
 
-SUBMINOR_VERSION:=32
+SUBMINOR_VERSION:=33
 
 # v0.9.31 requires libWEExtensions v4.2.52
 # v0.9.29 requires libWEExtensions v4.2.51
-- 
2.39.5