From a313c33a4ed3db7cfa1b77aaa2f3f52afc803d4d Mon Sep 17 00:00:00 2001
From: helge <helge@e4a50df8-12e2-0310-a44c-efbce7f8a7e3>
Date: Thu, 31 Aug 2006 00:44:33 +0000
Subject: [PATCH] embed labels in <label> tags

git-svn-id: http://svn.opengroupware.org/SOPE/trunk@1355 e4a50df8-12e2-0310-a44c-efbce7f8a7e3
---
 sope-appserver/NGObjWeb/ChangeLog             |  5 ++++
 .../NGObjWeb/DynamicElements/WOCheckBoxList.m | 23 +++++++++++--------
 sope-appserver/NGObjWeb/Version               |  2 +-
 3 files changed, 20 insertions(+), 10 deletions(-)

diff --git a/sope-appserver/NGObjWeb/ChangeLog b/sope-appserver/NGObjWeb/ChangeLog
index 992366b9..77426bb2 100644
--- a/sope-appserver/NGObjWeb/ChangeLog
+++ b/sope-appserver/NGObjWeb/ChangeLog
@@ -1,3 +1,8 @@
+2006-08-31  Wolfgang Sourdeau  <WSourdeau@Inverse.CA>
+
+	* DynamicElements/WOCheckBoxList.m: embed 'suffix' label binding in
+	  a label tag enclosing the checkbox (v4.5.245)
+
 2005-08-15  Sebastian Reitenbach  <reitenbach@rapideye.de>
 
 	* WOWatchDogApplicationMain.m: include <unistd.h> instead of
diff --git a/sope-appserver/NGObjWeb/DynamicElements/WOCheckBoxList.m b/sope-appserver/NGObjWeb/DynamicElements/WOCheckBoxList.m
index 4b924d58..8f96fba2 100644
--- a/sope-appserver/NGObjWeb/DynamicElements/WOCheckBoxList.m
+++ b/sope-appserver/NGObjWeb/DynamicElements/WOCheckBoxList.m
@@ -181,12 +181,18 @@
   
     /* add checkbox */
     {
-      NSString *n = nil;
+      NSString *n, *label;
   
-      n = self->name
+      label = [self->suffix stringValueInComponent:sComponent];
+      if (![label isNotEmpty]) label = nil; /* remove null/empty strings */
+      
+      n = self->name != nil
 	? [self->name stringValueInComponent:sComponent]
 	: OWFormElementName(self, _ctx);
-  
+      
+      if (label != nil)
+	WOResponse_AddCString(_response, "<label>");
+      
       WOResponse_AddCString(_response, "<input type=\"checkbox\" name=\"");
       [_response appendContentHTMLAttributeValue:n];
       WOResponse_AddCString(_response, "\" value=\"");
@@ -219,14 +225,13 @@
 	n = [self->value stringValueInComponent:sComponent];
 	WOResponse_AddHtmlString(_response, n);
       }
-    }
-    
-    if (self->suffix != nil) {
-      NSString *ss;
 
-      ss = [self->suffix stringValueInComponent:sComponent];
-      WOResponse_AddString(_response, ss);
+      if (label != nil) {
+	WOResponse_AddString(_response, label);
+	WOResponse_AddCString(_response, "</label>");
+      }
     }
+    
     [_ctx incrementLastElementIDComponent];
   }
   [_ctx deleteLastElementIDComponent]; // list index
diff --git a/sope-appserver/NGObjWeb/Version b/sope-appserver/NGObjWeb/Version
index 8186a383..ce37dc3a 100644
--- a/sope-appserver/NGObjWeb/Version
+++ b/sope-appserver/NGObjWeb/Version
@@ -1,6 +1,6 @@
 # version file
 
-SUBMINOR_VERSION:=244
+SUBMINOR_VERSION:=245
 
 # v4.5.234 requires libDOM          v4.5.21
 # v4.5.214 requires libNGExtensions v4.5.179
-- 
2.39.5