From 8ba13ec1cd00b86001b4344aec11ae0a64395f7b Mon Sep 17 00:00:00 2001 From: Kay Sievers Date: Thu, 9 Dec 2010 21:08:19 +0100 Subject: [PATCH] libudev: do not overwrite path with readlink() call --- libudev/libudev-util.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libudev/libudev-util.c b/libudev/libudev-util.c index 030b78cd..6c309afd 100644 --- a/libudev/libudev-util.c +++ b/libudev/libudev-util.c @@ -26,15 +26,16 @@ static ssize_t get_sys_link(struct udev *udev, const char *slink, const char *syspath, char *value, size_t size) { char path[UTIL_PATH_SIZE]; + char target[UTIL_PATH_SIZE]; ssize_t len; const char *pos; util_strscpyl(path, sizeof(path), syspath, "/", slink, NULL); - len = readlink(path, path, sizeof(path)); - if (len <= 0 || len == (ssize_t)sizeof(path)) + len = readlink(path, target, sizeof(target)); + if (len <= 0 || len == (ssize_t)sizeof(target)) return -1; - path[len] = '\0'; - pos = strrchr(path, '/'); + target[len] = '\0'; + pos = strrchr(target, '/'); if (pos == NULL) return -1; pos = &pos[1]; -- 2.39.5