From 891687649a5c44a1d53668b4f7728bf97c8db8d5 Mon Sep 17 00:00:00 2001 From: Patrick McHardy Date: Mon, 21 Jan 2008 00:14:05 -0800 Subject: [PATCH] [NET_SCHED]: sch_ingress: remove useless printk The printk about ingress qdisc registration error can't be triggered under normal circumstances. Since register_qdisc only fails for two identical registrations, the only way to trigger it is by loading the sch_ingress modules multiple times under different names, in which case we already return -EEXIST to userspace. Signed-off-by: Patrick McHardy Acked-by: Jamal Hadi Salim Signed-off-by: David S. Miller --- net/sched/sch_ingress.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/net/sched/sch_ingress.c b/net/sched/sch_ingress.c index 4c7f7e7129..72525710b6 100644 --- a/net/sched/sch_ingress.c +++ b/net/sched/sch_ingress.c @@ -221,14 +221,7 @@ static struct Qdisc_ops ingress_qdisc_ops __read_mostly = { static int __init ingress_module_init(void) { - int ret = 0; - - if ((ret = register_qdisc(&ingress_qdisc_ops)) < 0) { - printk("Unable to register Ingress qdisc\n"); - return ret; - } - - return ret; + return register_qdisc(&ingress_qdisc_ops); } static void __exit ingress_module_exit(void) -- 2.39.5