From 8083af64c7edd9f77f091b7b2b0dd07a3bb8a8f6 Mon Sep 17 00:00:00 2001 From: phk Date: Wed, 23 Jan 2008 10:13:43 +0000 Subject: [PATCH] mgt_cli_askchild() always returns a pointer. Coverity Scan (CID:12) git-svn-id: svn+ssh://projects.linpro.no/svn/varnish/trunk@2372 d4fa192b-c00b-0410-8231-f00ffab90ce4 --- varnish-cache/bin/varnishd/mgt_vcc.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/varnish-cache/bin/varnishd/mgt_vcc.c b/varnish-cache/bin/varnishd/mgt_vcc.c index b912ffdc..3dc20975 100644 --- a/varnish-cache/bin/varnishd/mgt_vcc.c +++ b/varnish-cache/bin/varnishd/mgt_vcc.c @@ -592,10 +592,12 @@ mcf_config_use(struct cli *cli, const char * const *av, void *priv) (void)priv; vp = mcf_find_vcl(cli, av[2]); if (vp != NULL && vp->active == 0) { - if (child_pid >= 0 && - mgt_cli_askchild(&status, &p, "vcl.use %s\n", av[2])) { - cli_result(cli, status); - cli_out(cli, "%s", p); + if (child_pid >= 0) { + if (mgt_cli_askchild(&status, &p, + "vcl.use %s\n", av[2])) { + cli_result(cli, status); + cli_out(cli, "%s", p); + } free(p); } else { vp->active = 2; -- 2.39.5