From 77d5f105bf63330350c7bddacdeda914f945590f Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Wed, 25 Aug 2010 04:58:16 +0200 Subject: [PATCH] cgroup: mount cgroup file systems to /sys/fs/cgroup instead of /cgroup This requires the /sys/fs/cgroup to exist. Current git kernels have this, released kernels need a backport of a single patch. --- Makefile.am | 2 -- man/sd_booted.xml | 6 +++--- man/systemd-cgls.xml | 2 +- man/systemd.xml | 2 +- src/cgls.c | 2 +- src/cgroup-util.c | 4 ++-- src/mount-setup.c | 18 +++++++++--------- src/sd-daemon.c | 4 ++-- src/test-cgroup.c | 2 +- 9 files changed, 20 insertions(+), 22 deletions(-) diff --git a/Makefile.am b/Makefile.am index 859d3326..725685df 100644 --- a/Makefile.am +++ b/Makefile.am @@ -847,8 +847,6 @@ install-data-hook: $(DESTDIR)$(pkgsysconfdir)/system/graphical.target.wants \ $(DESTDIR)$(pkgsysconfdir)/session \ $(DESTDIR)$(sysconfdir)/xdg/systemd - $(MKDIR_P) -m 0755 $(DESTDIR)/cgroup || \ - echo "Don't forget to create /cgroup! Couldn't create it for you, continuing anyway." ( cd $(DESTDIR)$(sysconfdir)/xdg/systemd/ && \ rm -f session && \ $(LN_S) $(pkgsysconfdir)/session session ) diff --git a/man/sd_booted.xml b/man/sd_booted.xml index 15cd6ce4..841ee1d4 100644 --- a/man/sd_booted.xml +++ b/man/sd_booted.xml @@ -85,11 +85,11 @@ implementation. Internally, this function checks whether the - /cgroup/systemd virtual file + /sys/fs/cgroup/systemd virtual file system is mounted, by comparing the st_dev value of the stat() data of - /cgroup and - /cgroup/systemd. + /sys/fs/cgroup and + /sys/fs/cgroup/systemd. For details about the algorithm check the liberally licensed reference implementation sources: diff --git a/man/systemd-cgls.xml b/man/systemd-cgls.xml index da3e0cac..8546e394 100644 --- a/man/systemd-cgls.xml +++ b/man/systemd-cgls.xml @@ -65,7 +65,7 @@ file paths or are assumed in the systemd control group hierarchy. If no argument is specified and the current working directory is beneath the control group mount - point /cgroup shows the contents + point /sys/fs/cgroup shows the contents of the control group the working directory refers to. Otherwise the full systemd control group hierarchy is shown. diff --git a/man/systemd.xml b/man/systemd.xml index 6edce499..edd824d3 100644 --- a/man/systemd.xml +++ b/man/systemd.xml @@ -388,7 +388,7 @@ track of processes. Control group information is maintained in the kernel, and is accessible via the file system hierarchy (beneath - /cgroup/systemd/), or in tools + /sys/fs/cgroup/systemd/), or in tools such as ps1 (ps xawf -eo pid,user,cgroup,args diff --git a/src/cgls.c b/src/cgls.c index 2940e372..f1f3046e 100644 --- a/src/cgls.c +++ b/src/cgls.c @@ -103,7 +103,7 @@ int main(int argc, char *argv[]) { goto finish; } - if (path_startswith(p, "/cgroup")) { + if (path_startswith(p, "/sys/fs/cgroup")) { printf("Working Directory %s:\n", p); r = show_cgroup_by_path(p, NULL, 0); } else diff --git a/src/cgroup-util.c b/src/cgroup-util.c index 07e4e64f..6abb6b54 100644 --- a/src/cgroup-util.c +++ b/src/cgroup-util.c @@ -481,7 +481,7 @@ int cg_get_path(const char *controller, const char *path, const char *suffix, ch else p = controller; - if (asprintf(&mp, "/cgroup/%s", p) < 0) + if (asprintf(&mp, "/sys/fs/cgroup/%s", p) < 0) return -ENOMEM; if ((r = path_is_mount_point(mp)) <= 0) { @@ -927,7 +927,7 @@ int cg_fix_path(const char *path, char **result) { /* First check if it already is a filesystem path */ if (path_is_absolute(path) && - path_startswith(path, "/cgroup") && + path_startswith(path, "/sys/fs/cgroup") && access(path, F_OK) >= 0) { if (!(t = strdup(path))) diff --git a/src/mount-setup.c b/src/mount-setup.c index 8b4d8c7f..c1ddbe45 100644 --- a/src/mount-setup.c +++ b/src/mount-setup.c @@ -42,13 +42,13 @@ typedef struct MountPoint { } MountPoint; static const MountPoint mount_table[] = { - { "proc", "/proc", "proc", NULL, MS_NOSUID|MS_NOEXEC|MS_NODEV, true }, - { "sysfs", "/sys", "sysfs", NULL, MS_NOSUID|MS_NOEXEC|MS_NODEV, true }, - { "devtmpfs", "/dev", "devtmpfs", "mode=755", MS_NOSUID, true }, - { "tmpfs", "/dev/shm", "tmpfs", "mode=1777", MS_NOSUID|MS_NOEXEC|MS_NODEV, true }, - { "devpts", "/dev/pts", "devpts", NULL, MS_NOSUID|MS_NOEXEC, false }, - { "tmpfs", "/cgroup", "tmpfs", "mode=755", MS_NOSUID|MS_NOEXEC|MS_NODEV, true }, - { "cgroup", "/cgroup/systemd", "cgroup", "none,name=systemd", MS_NOSUID|MS_NOEXEC|MS_NODEV, true }, + { "proc", "/proc", "proc", NULL, MS_NOSUID|MS_NOEXEC|MS_NODEV, true }, + { "sysfs", "/sys", "sysfs", NULL, MS_NOSUID|MS_NOEXEC|MS_NODEV, true }, + { "devtmpfs", "/dev", "devtmpfs", "mode=755", MS_NOSUID, true }, + { "tmpfs", "/dev/shm", "tmpfs", "mode=1777", MS_NOSUID|MS_NOEXEC|MS_NODEV, true }, + { "devpts", "/dev/pts", "devpts", NULL, MS_NOSUID|MS_NOEXEC, false }, + { "tmpfs", "/sys/fs/cgroup", "tmpfs", "mode=755", MS_NOSUID|MS_NOEXEC|MS_NODEV, true }, + { "cgroup", "/sys/fs/cgroup/systemd", "cgroup", "none,name=systemd", MS_NOSUID|MS_NOEXEC|MS_NODEV, true }, }; /* These are API file systems that might be mounted by other software, @@ -75,7 +75,7 @@ bool mount_point_is_api(const char *path) { if (path_equal(path, ignore_paths[i])) return true; - return path_startswith(path, "/cgroup/"); + return path_startswith(path, "/sys/fs/cgroup/"); } static int mount_one(const MountPoint *p) { @@ -138,7 +138,7 @@ static int mount_cgroup_controllers(void) { goto finish; } - if (asprintf(&where, "/cgroup/%s", controller) < 0) { + if (asprintf(&where, "/sys/fs/cgroup/%s", controller) < 0) { free(controller); r = -ENOMEM; goto finish; diff --git a/src/sd-daemon.c b/src/sd-daemon.c index 33970f6c..9b4e0103 100644 --- a/src/sd-daemon.c +++ b/src/sd-daemon.c @@ -441,10 +441,10 @@ int sd_booted(void) { /* We simply test whether the systemd cgroup hierarchy is * mounted */ - if (lstat("/cgroup", &a) < 0) + if (lstat("/sys/fs/cgroup", &a) < 0) return 0; - if (lstat("/cgroup/systemd", &b) < 0) + if (lstat("/sys/fs/cgroup/systemd", &b) < 0) return 0; return a.st_dev != b.st_dev; diff --git a/src/test-cgroup.c b/src/test-cgroup.c index bebca7b5..63329a39 100644 --- a/src/test-cgroup.c +++ b/src/test-cgroup.c @@ -53,7 +53,7 @@ int main(int argc, char*argv[]) { free(path); assert_se(cg_get_path(SYSTEMD_CGROUP_CONTROLLER, "/test-b/test-d", NULL, &path) == 0); - assert_se(path_equal(path, "/cgroup/systemd/test-b/test-d")); + assert_se(path_equal(path, "/sys/fs/cgroup/systemd/test-b/test-d")); free(path); assert_se(cg_is_empty(SYSTEMD_CGROUP_CONTROLLER, "/test-a", false) > 0); -- 2.39.5