From 705a165d4d7cea43cec11eaaaaf51b16806edf68 Mon Sep 17 00:00:00 2001 From: Kay Sievers Date: Thu, 7 Jul 2011 20:02:41 +0200 Subject: [PATCH] enforce valid TAG+= names --- udev/udev-rules.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/udev/udev-rules.c b/udev/udev-rules.c index 56a258d8..d16c1f94 100644 --- a/udev/udev-rules.c +++ b/udev/udev-rules.c @@ -2528,10 +2528,20 @@ int udev_rules_apply_to_event(struct udev_rules *rules, struct udev_event *event } case TK_A_TAG: { char tag[UTIL_PATH_SIZE]; + const char *p; udev_event_apply_format(event, &rules->buf[cur->key.value_off], tag, sizeof(tag)); if (cur->key.op == OP_ASSIGN || cur->key.op == OP_ASSIGN_FINAL) udev_device_cleanup_tags_list(event->dev); + for (p = tag; *p != '\0'; p++) { + if ((*p >= 'a' && *p <= 'z') || + (*p >= 'A' && *p <= 'Z') || + (*p >= '0' && *p <= '9') || + *p == '-' || *p == '_') + continue; + err(event->udev, "ignoring invalid tag name '%s'\n", tag); + break; + } udev_device_add_tag(event->dev, tag); break; } -- 2.39.5