From 4f47707b056bd2e3627ef390557ee93d312daba5 Mon Sep 17 00:00:00 2001 From: Linus Torvalds Date: Tue, 10 Jan 2006 08:56:39 -0800 Subject: [PATCH] Fix rpc shutdown event condition bug We want to wait for the cl_users to go down to zero, not for it to stay positive. Quoth Trond (who wasn't even the author, but acked the wrong version): "Argh! I need to increase my daily caffeine dosages." Signed-off-by: Linus Torvalds --- net/sunrpc/clnt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c index a44da8b3d2..4cef7fa2b7 100644 --- a/net/sunrpc/clnt.c +++ b/net/sunrpc/clnt.c @@ -269,7 +269,7 @@ rpc_shutdown_client(struct rpc_clnt *clnt) clnt->cl_dead = 0; rpc_killall_tasks(clnt); wait_event_timeout(destroy_wait, - atomic_read(&clnt->cl_users) > 0, 1*HZ); + !atomic_read(&clnt->cl_users), 1*HZ); } if (atomic_read(&clnt->cl_users) < 0) { -- 2.39.5