From 3cc3816f93e3f94f88503da8e6090302fa986bd6 Mon Sep 17 00:00:00 2001 From: Herbert Xu Date: Wed, 22 Jun 2005 13:26:36 -0700 Subject: [PATCH] [CRYPTO]: Kill unnecessary strncpy from tcrypt It seems that bad code tends to get copied (see test_cipher_speed). So let's kill this idiom before it spreads any further. Signed-off-by: Herbert Xu Signed-off-by: David S. Miller --- crypto/tcrypt.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c index 5a95b4a14c..85a88a71ff 100644 --- a/crypto/tcrypt.c +++ b/crypto/tcrypt.c @@ -266,16 +266,16 @@ static void test_cipher(char *algo, int mode, int enc, char *key; struct cipher_testvec *cipher_tv; struct scatterlist sg[8]; - char e[11], m[4]; + const char *e, *m; if (enc == ENCRYPT) - strncpy(e, "encryption", 11); + e = "encryption"; else - strncpy(e, "decryption", 11); + e = "decryption"; if (mode == MODE_ECB) - strncpy(m, "ECB", 4); + m = "ECB"; else - strncpy(m, "CBC", 4); + m = "CBC"; printk("\ntesting %s %s %s\n", algo, m, e); -- 2.39.5