From 395ea97815f0ca2352caeccf3027d026dd9e58a7 Mon Sep 17 00:00:00 2001 From: Kay Sievers Date: Fri, 4 May 2012 02:26:08 +0200 Subject: [PATCH] udev: fix the ENV{} blacklist logic --- src/udev/udev-rules.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/udev/udev-rules.c b/src/udev/udev-rules.c index a800ccdc..e73b1561 100644 --- a/src/udev/udev-rules.c +++ b/src/udev/udev-rules.c @@ -1349,11 +1349,12 @@ static int add_rule(struct udev_rules *rules, char *line, }; unsigned int i; - for (i = 0; i < ELEMENTSOF(blacklist); i++) - if (streq(attr, blacklist[i])) { - log_error("invalid ENV attribute, '%s' can not be set %s:%u\n", attr, filename, lineno); + for (i = 0; i < ELEMENTSOF(blacklist); i++) { + if (!streq(attr, blacklist[i])) continue; - } + log_error("invalid ENV attribute, '%s' can not be set %s:%u\n", attr, filename, lineno); + goto invalid; + } if (rule_add_key(&rule_tmp, TK_A_ENV, op, value, attr) != 0) goto invalid; } -- 2.39.5