From 2e9d6c1251abc0af9aa5bc53610bd522d55be776 Mon Sep 17 00:00:00 2001 From: David Ward Date: Sun, 29 Apr 2012 09:35:51 -0400 Subject: [PATCH] service: fix auto-restart handling in service_start() Do not bypass the SERVICE_DEAD/SERVICE_FAILED state by manually issuing a start job while an automatic restart is pending. --- src/core/service.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/core/service.c b/src/core/service.c index 9512e0e9..5d82e9b5 100644 --- a/src/core/service.c +++ b/src/core/service.c @@ -2436,7 +2436,16 @@ static int service_start(Unit *u) { s->state == SERVICE_START_POST) return 0; - assert(s->state == SERVICE_DEAD || s->state == SERVICE_FAILED || s->state == SERVICE_AUTO_RESTART); + /* A service that will be restarted must be stopped first to + * trigger BindTo and/or OnFailure dependencies. If a user + * does not want to wait for the holdoff time to elapse, the + * service should be manually restarted, not started. */ + if (s->state == SERVICE_AUTO_RESTART) { + log_warning("%s automatic restart is pending, must be stopped before issuing start request.", UNIT(s)->id); + return -ECANCELED; + } + + assert(s->state == SERVICE_DEAD || s->state == SERVICE_FAILED); /* Make sure we don't enter a busy loop of some kind. */ r = service_start_limit_test(s); -- 2.39.5