From 245252bb940148bd174a20b79dcf7c3d274da9ce Mon Sep 17 00:00:00 2001 From: Mike Sheldon Date: Thu, 26 Mar 2009 00:33:03 +0200 Subject: [PATCH] Fix Bug 576698: Segfault on 32bits platform This assumes that tile numbers are at most 3 characters long, which isn't the case. Resulting in "g_sprintf (value, "%d", number);" corrupting the stack and causing the segfault. --- champlain/champlain-network-map-source.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/champlain/champlain-network-map-source.c b/champlain/champlain-network-map-source.c index 3efb38a..b128840 100644 --- a/champlain/champlain-network-map-source.c +++ b/champlain/champlain-network-map-source.c @@ -225,6 +225,7 @@ champlain_network_map_source_new_full (const gchar *name, return network_map_source; } +#define SIZE 8 gchar * champlain_network_map_source_get_tile_uri (ChamplainNetworkMapSource *network_map_source, gint x, @@ -245,7 +246,7 @@ champlain_network_map_source_get_tile_uri (ChamplainNetworkMapSource *network_ma while (token != NULL) { gint number = G_MAXINT; - gchar value[3]; + gchar value[SIZE]; if (strcmp (token, "X") == 0) number = x; @@ -256,7 +257,7 @@ champlain_network_map_source_get_tile_uri (ChamplainNetworkMapSource *network_ma if (number != G_MAXINT) { - g_sprintf (value, "%d", number); + g_snprintf (value, SIZE, "%d", number); g_string_append (ret, value); } else -- 2.39.5