From 177b3ffedbfc1aea839324edeb1f35a1a754ef5b Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Fri, 18 Mar 2011 03:32:33 +0100 Subject: [PATCH] special: get rid of dbus.target --- Makefile.am | 1 - man/systemd.service.xml | 2 +- man/systemd.special.xml.in | 23 ----------------------- src/service.c | 2 +- src/special.h | 37 ++++++++++++++++++++----------------- units/dbus.target | 11 ----------- 6 files changed, 22 insertions(+), 54 deletions(-) delete mode 100644 units/dbus.target diff --git a/Makefile.am b/Makefile.am index 8d234303..a94d2a7f 100644 --- a/Makefile.am +++ b/Makefile.am @@ -229,7 +229,6 @@ dist_systemunit_DATA = \ units/sigpwr.target \ units/sockets.target \ units/swap.target \ - units/dbus.target \ units/systemd-initctl.socket \ units/systemd-logger.socket \ units/systemd-shutdownd.socket \ diff --git a/man/systemd.service.xml b/man/systemd.service.xml index 7200525c..e444efeb 100644 --- a/man/systemd.service.xml +++ b/man/systemd.service.xml @@ -180,7 +180,7 @@ acquired. Service units with this option configured implicitly gain dependencies on the - dbus.target + dbus.socket unit. Behaviour of diff --git a/man/systemd.special.xml.in b/man/systemd.special.xml.in index afe882e5..1506f349 100644 --- a/man/systemd.special.xml.in +++ b/man/systemd.special.xml.in @@ -51,7 +51,6 @@ basic.target, ctrl-alt-del.target, dbus.service, - dbus.target, default.target, display-manager.service, emergency.target, @@ -143,28 +142,6 @@ up systemd will connect to it and register its service. - - Units should generally - avoid depending on this unit - directly and instead refer to - the - dbus.target - unit instead, which pulls this - one in directly or indirectly - via socket-based activation. - - - - dbus.target - - Administrators should - ensure that this target pulls - in a service unit with the - name or alias of - dbus.service - (or a socket unit that - activates this - service). diff --git a/src/service.c b/src/service.c index 0f28312b..f0c72f2c 100644 --- a/src/service.c +++ b/src/service.c @@ -1129,7 +1129,7 @@ static int service_load(Unit *u) { s->notify_access = NOTIFY_MAIN; if (s->type == SERVICE_DBUS || s->bus_name) - if ((r = unit_add_two_dependencies_by_name(u, UNIT_AFTER, UNIT_REQUIRES, SPECIAL_DBUS_TARGET, NULL, true)) < 0) + if ((r = unit_add_two_dependencies_by_name(u, UNIT_AFTER, UNIT_REQUIRES, SPECIAL_DBUS_SOCKET, NULL, true)) < 0) return r; if (s->meta.default_dependencies) diff --git a/src/special.h b/src/special.h index 2f2d9e7b..ba2bc143 100644 --- a/src/special.h +++ b/src/special.h @@ -30,17 +30,24 @@ * system shutdown. */ #define SPECIAL_SHUTDOWN_TARGET "shutdown.target" #define SPECIAL_UMOUNT_TARGET "umount.target" +#define SPECIAL_HALT_TARGET "halt.target" +#define SPECIAL_POWEROFF_TARGET "poweroff.target" +#define SPECIAL_REBOOT_TARGET "reboot.target" +#define SPECIAL_KEXEC_TARGET "kexec.target" +#define SPECIAL_EXIT_TARGET "exit.target" -#define SPECIAL_LOGGER_SOCKET "systemd-logger.socket" - -#define SPECIAL_KBREQUEST_TARGET "kbrequest.target" -#define SPECIAL_SIGPWR_TARGET "sigpwr.target" -#define SPECIAL_CTRL_ALT_DEL_TARGET "ctrl-alt-del.target" +#define SPECIAL_RESCUE_TARGET "rescue.target" +#define SPECIAL_EMERGENCY_TARGET "emergency.target" +#define SPECIAL_SYSINIT_TARGET "sysinit.target" +#define SPECIAL_SOCKETS_TARGET "sockets.target" #define SPECIAL_LOCAL_FS_TARGET "local-fs.target" /* LSB's $local_fs */ #define SPECIAL_REMOTE_FS_TARGET "remote-fs.target" /* LSB's $remote_fs */ #define SPECIAL_SWAP_TARGET "swap.target" +#define SPECIAL_BASIC_TARGET "basic.target" + #define SPECIAL_NETWORK_TARGET "network.target" /* LSB's $network */ + #define SPECIAL_NSS_LOOKUP_TARGET "nss-lookup.target" /* LSB's $named */ #define SPECIAL_RPCBIND_TARGET "rpcbind.target" /* LSB's $portmap */ #define SPECIAL_SYSLOG_TARGET "syslog.target" /* LSB's $syslog; Should pull in syslog.socket or syslog.service */ @@ -48,22 +55,18 @@ #define SPECIAL_DISPLAY_MANAGER_SERVICE "display-manager.service" /* Debian's $x-display-manager */ #define SPECIAL_MAIL_TRANSFER_AGENT_TARGET "mail-transfer-agent.target" /* Debian's $mail-{transport|transfer-agent */ #define SPECIAL_HTTP_DAEMON_TARGET "http-daemon.target" -#define SPECIAL_DBUS_TARGET "dbus.target" -#define SPECIAL_BASIC_TARGET "basic.target" -#define SPECIAL_SOCKETS_TARGET "sockets.target" -#define SPECIAL_SYSINIT_TARGET "sysinit.target" + #define SPECIAL_FSCK_SERVICE "fsck@.service" #define SPECIAL_QUOTACHECK_SERVICE "quotacheck.service" -#define SPECIAL_RESCUE_TARGET "rescue.target" -#define SPECIAL_EXIT_TARGET "exit.target" -#define SPECIAL_EMERGENCY_TARGET "emergency.target" -#define SPECIAL_HALT_TARGET "halt.target" -#define SPECIAL_POWEROFF_TARGET "poweroff.target" -#define SPECIAL_REBOOT_TARGET "reboot.target" -#define SPECIAL_KEXEC_TARGET "kexec.target" +#define SPECIAL_REMOUNT_ROOTFS_SERVICE "remount-rootfs.service" + #define SPECIAL_DBUS_SERVICE "dbus.service" #define SPECIAL_DBUS_SOCKET "dbus.socket" -#define SPECIAL_REMOUNT_ROOTFS_SERVICE "remount-rootfs.service" +#define SPECIAL_LOGGER_SOCKET "systemd-logger.socket" + +#define SPECIAL_KBREQUEST_TARGET "kbrequest.target" +#define SPECIAL_SIGPWR_TARGET "sigpwr.target" +#define SPECIAL_CTRL_ALT_DEL_TARGET "ctrl-alt-del.target" #ifndef SPECIAL_SYSLOG_SERVICE #define SPECIAL_SYSLOG_SERVICE "syslog.service" diff --git a/units/dbus.target b/units/dbus.target deleted file mode 100644 index 63897685..00000000 --- a/units/dbus.target +++ /dev/null @@ -1,11 +0,0 @@ -# This file is part of systemd. -# -# systemd is free software; you can redistribute it and/or modify it -# under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 2 of the License, or -# (at your option) any later version. - -# See systemd.special(7) for details - -[Unit] -Description=D-Bus -- 2.39.5