From 0ff304e2ca860e51e75bbfc08290e364e94cb32e Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Fri, 11 Apr 2008 15:53:38 -0400 Subject: [PATCH] set up signal handlers before creating temp file Avoids a small race.. --- sponge.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/sponge.c b/sponge.c index a88fe0e..66fd97d 100644 --- a/sponge.c +++ b/sponge.c @@ -237,10 +237,13 @@ int main (int argc, char **argv) { if ((bufsize*2) >= mem_available) { if (!tmpfile) { /* umask(077); FIXME: Should we be setting umask, or using default? */ - struct cs_status cs = cs_enter(); - int tmpfd = mkstemp(tmpname); - atexit(onexit_cleanup); // solaris on_exit(onexit_cleanup, 0); + struct cs_status cs; + int tmpfd; + trapsignals(); + cs = cs_enter(); + tmpfd = mkstemp(tmpname); + atexit(onexit_cleanup); // solaris on_exit(onexit_cleanup, 0); cs_leave(cs); if (tmpfd < 0) { perror("mkstemp failed"); -- 2.39.5