From 0ecfcbd4f758f9ff10926156eb8c7a7542650627 Mon Sep 17 00:00:00 2001 From: Kay Sievers Date: Mon, 23 Jan 2012 05:00:59 +0100 Subject: [PATCH] print warning when rules try to rename kernel device nodes --- src/udev-rules.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/udev-rules.c b/src/udev-rules.c index 8efc498f..a5b4b730 100644 --- a/src/udev-rules.c +++ b/src/udev-rules.c @@ -2546,6 +2546,7 @@ int udev_rules_apply_to_event(struct udev_rules *rules, struct udev_event *event } case TK_A_NAME: { const char *name = &rules->buf[cur->key.value_off]; + char name_str[UTIL_PATH_SIZE]; int count; @@ -2559,6 +2560,16 @@ int udev_rules_apply_to_event(struct udev_rules *rules, struct udev_event *event if (count > 0) info(event->udev, "%i character(s) replaced\n", count); } + if (major(udev_device_get_devnum(event->dev))) { + size_t devlen = strlen(udev_get_dev_path(event->udev))+1; + + if (strcmp(name_str, &udev_device_get_devnode(event->dev)[devlen]) != 0) { + err(event->udev, "NAME=\"%s\" ignored, kernel device nodes " + "can not be renamed; please fix it in %s:%u\n", name, + &rules->buf[rule->rule.filename_off], rule->rule.filename_line); + break; + } + } free(event->name); event->name = strdup(name_str); info(event->udev, "NAME '%s' %s:%u\n", -- 2.39.5