]> err.no Git - linux-2.6/commit
[PATCH] Fix up mmap_kmem
authorFranck Bui-Huu <fbuihuu@gmail.com>
Thu, 12 Oct 2006 19:06:33 +0000 (21:06 +0200)
committerLinus Torvalds <torvalds@g5.osdl.org>
Fri, 13 Oct 2006 15:35:38 +0000 (08:35 -0700)
commit99a10a60ba9bedcf5d70ef81414d3e03816afa3f
tree7ea2c86ddd2bfdab885fe86f1c60d412e5730bb1
parenta5344a9555fffd045218aced89afd6ca0f884e10
[PATCH] Fix up mmap_kmem

vma->vm_pgoff is an pfn _offset_ relatif to the begining
of the memory start. The previous code was doing at first:

vma->vm_pgoff << PAGE_SHIFT

which results into a wrong physical address since some
platforms have a physical mem start that can be different
from 0. After that the previous call __pa() on this
wrong physical address, however __pa() is used to convert
a _virtual_ address into a physical one.

This patch rewrites this convertion. It calculates the
pfn of PAGE_OFFSET which is the pfn of the mem start
then it adds the vma->vm_pgoff to it.

It also uses virt_to_phys() instead of __pa() since the
latter shouldn't be used by drivers.

Signed-off-by: Franck Bui-Huu <fbuihuu@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/char/mem.c