]> err.no Git - linux-2.6/commit
sysctl: update sysctl_check_table
authorEric W. Biederman <ebiederm@xmission.com>
Thu, 18 Oct 2007 10:05:57 +0000 (03:05 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Thu, 18 Oct 2007 21:37:23 +0000 (14:37 -0700)
commit49ffcf8f99e8d33ec8afb450956804af518fd788
treef55aac9ddebb4f798ba8ff8152c73a73a3dc93a2
parentfc6cd25b738c2369d7ed3a6ef2ca248b51fcd2d4
sysctl: update sysctl_check_table

Well it turns out after I dug into the problems a little more I was returning
a few false positives so this patch updates my logic to remove them.

- Don't complain about 0 ctl_names in sysctl_check_binary_path
  It is valid for someone to remove the sysctl binary interface
  and still keep the same sysctl proc interface.

- Count ctl_names and procnames as matching if they both don't
  exist.

- Only warn about missing min&max when the generic functions care.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Cc: Alexey Dobriyan <adobriyan@sw.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/sysctl_check.c