Karel Zak [Wed, 14 May 2008 14:38:47 +0000 (16:38 +0200)]
mount: remount doesn't care about loop=
The command
# mount -oremount <spec> <dir>
doesn't read fstab or mtab. This is expected behaviour. Unfortunately,
we have to care about the internal loop= option which is generated and
maintained by mount(8)/umount(8). The loop= option has to be persistent.
How to reproduce this bug:
# mount -o loop /home/images/vfat.img /mnt/img; grep vfat /etc/mtab; \
mount -o remount,ro /home/images/vfat.img /mnt/img; grep vfat /etc/mtab;
Karel Zak [Tue, 13 May 2008 12:00:39 +0000 (14:00 +0200)]
setarch: add fallback for linux/personality
setarch.c:248: error: 'ADDR_NO_RANDOMIZE' undeclared (first use in this function)
setarch.c:248: error: (Each undeclared identifier is reported only once
setarch.c:248: error: for each function it appears in.)
setarch.c:251: error: 'FDPIC_FUNCPTRS' undeclared (first use in this function)
setarch.c:257: error: 'ADDR_COMPAT_LAYOUT' undeclared (first use in this function)
setarch.c:260: error: 'READ_IMPLIES_EXEC' undeclared (first use in this function)
Linux gzp1 2.4.36.1-gzp1 #1 SMP Tue Feb 19 10:23:48 CET 2008 i686 GNU/Linux
Reported-By: Gabor Z. Papp <gzp@papp.hu> Signed-off-by: Karel Zak <kzak@redhat.com>
Steve Grubb [Sat, 19 Apr 2008 15:49:02 +0000 (11:49 -0400)]
login: audit log injection attack via login
A while back I found a couple audit log injection attacks which became
CVE-2007-3102. I forgot to look at login to see if its vulnerable and Mirek
found that it is. To verify the problem, type:
root addr=xyz.com
for the account name while logging in. It will look like root logged in with
an address of xyz.com.
mount: add support for sizelimit= mount option (for loop mounts)
[kzak@redhat.com: split the original patch to small patches] Signed-off-by: Shachar Shemesh <shachar@lingnu.com> Signed-off-by: Karel Zak <kzak@redhat.com>
[kzak@redhat.com: split the original patch to small patches] Signed-off-by: Shachar Shemesh <shachar@debian.org> Signed-off-by: Karel Zak <kzak@redhat.com>
James Youngman [Sun, 6 Apr 2008 10:45:57 +0000 (11:45 +0100)]
fsck.minix: correct the error message given when we can't open the device
Don't actually print %s in the error message, print the device name,
as was obviously intended. Also, print the error message
corresponding to the errno value.
[kzak@redhat.com: add __attribute__, coding style cleanups] Signed-off-by: James Youngman <jay@gnu.org> Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Wed, 2 Apr 2008 11:46:26 +0000 (13:46 +0200)]
mount: remove built-in support for background mounts
EX_BG is archaism from old integrated NFS code. The built-in NFS code
has been removed in the previous version and all "bg" stuff is handled
by /sbin/mount.nfs. It seems we can remove all "bg" stuff from
mount(8).
Karel Zak [Thu, 20 Mar 2008 13:54:06 +0000 (14:54 +0100)]
mkswap: fix compiler warnings
mkswap.c:529: warning: pointer targets in assignment differ in signedness
mkswap.c:531: warning: pointer targets in assignment differ in signedness
mkswap.c:550: warning: pointer targets in passing argument 1 of `uuid_parse' differ in signedness
Kees Cook [Thu, 20 Mar 2008 08:24:03 +0000 (01:24 -0700)]
swapon: Reinitialize software suspend areas to avoid future corruption.
This is based on the earlier swsuspend re-init patch carried by
RedHat, SuSE, and Ubuntu. It has been updated to include passing
the known UUID to mkswap, and fixing the fstype name.
Co-Author: Karel Zak <kzak@redhat.com> Signed-off-by: Kees Cook <kees.cook@canonical.com> Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 4 Mar 2008 23:53:24 +0000 (00:53 +0100)]
build-sys: use ncursesw (wide version) when possibe
Detect ncursesw and use it in place of ncurses when possible
(default). Allow people to use classic (non-wide) version by
--with-ncurses or disable all ncurses/ncursesw support by
--without-ncurses.
Co-Author: Mike Frysinger <vapier@gentoo.org> Signed-off-by: Karel Zak <kzak@redhat.com>
Karel Zak [Tue, 4 Mar 2008 23:34:49 +0000 (00:34 +0100)]
build-sys: add VARSUFFIX to UTIL_CHECK_LIB
The UTIL_CHECK_LIB macro follows the default autoconf behaviour and
generates have_<libname> and HAVE_LIB<LIBNAME> variables.
Some libraries are substitutional (e.g. ncurses and ncursesw). It would be
nice to generate for that libraries the same HAVE_ variables independently
on a library name.
This patch adds optional VARSUFFIX option to UTIL_CHECK_LIB, so the final
variables are have_<varsuffix> and HAVE_LIB<VARSUFFIX>.
For example:
UTIL_CHECK_LIB(yyy, func) generates have_yyy and HAVE_LIBYYY
UTIL_CHECK_LIB(yyy, func, xxx) generates have_xxx and HAVE_LIBXXX
Jim Meyering [Wed, 12 Mar 2008 10:42:16 +0000 (11:42 +0100)]
remove useless if-before-free tests.
E.g., in this example, the "if (p)" test is useless.
if (p)
free (p);
I've been removing such tests systematically.
Here's where I proposed it to the git folks, along with justification
for why it's ok to perform this transformation, these days (no one
uses SunOS4 anymore):
Hamish Coleman [Mon, 3 Mar 2008 16:52:59 +0000 (09:52 -0700)]
agetty: make username-in-uppercase feature optional (off by default.)
The following patch makes the username-in-upper-case feature optional.
I have chosen to make it default to off since this feature was designed
to cater for serial terminals that were last sold almost 30 years ago,
thus the likelyhood that anyone will need this feature turned on is
vanishingly small.
Addresses-Debian-Bug: 156242 Signed-off-by: Hamish Coleman <hamish@zot.org> Signed-off-by: LaMont Jones <lamont@debian.org> Signed-off-by: Karel Zak <kzak@redhat.com>
projects / util-linux / log