libblkid: fix segfault in blkid_do_probe()

This:
pr->cur_chain += sizeof(struct blkid_chain);

is nonsense of course, there should be a cast to (char *) or so.

It seems that the most robust solution is to avoid this game with
pointers and use chain->driver-id which is useful as array index.

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: fix non-magic FAT detection

On Wed, Sep 30, 2009 at 03:15:41PM +0200, Lawrence Rust wrote:
> The problem is with shlibs/blkid/src/probers/vfat.c.  At the end of
> this file  the struct blkid_idinfo is declared with some magic
> search strings.   In particular, 2 patterns are defined to match the
> single byte jmp/jxx opcodes at the start of a DOS boot sector.
> Because the partition was once formatted as a bootable DOS
> partition it matches these patterns and consequently the function
> probe_vfat is called.  For these simple pattern matches the function
> probe_fat_nomagic is called to filter out false positives.
>
> In normal circumstances only MSDOS 2 and earlier floppies should be
> detected by this function.  A very important feature of these disks
> is the boot signature - bytes 0x55, 0xaa at the end of the 1st
> sector which indicate to the BIOS that  the disk is bootable.  All
> MSDOS floppies have these bytes but the function probe_fat_nomagic
> doesn't check for them.

Note that the msdos/vfat superblock comments has been suggested by
Lawrence.

Reported-by: Lawrence Rust <lawrence@softsystem.co.uk>
Signed-off-by: Karel Zak <kzak@redhat.com>

mount: more verbose "mount: only root can do that" message

> [chroot-i486] root:/$ whoami
> root
> [chroot-i486] root:/$ mkdir -p /dev1
> [chroot-i486] root:/$ mount --move /dev /dev1
> mount: only root can do that

Reported-by: Gilles Espinasse <g.esp@free.fr>
Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: add --disable-makeinstall-setuid

.. to disable "chmod 4755" for mount and umount.

Signed-off-by: Karel Zak <kzak@redhat.com>

lib: fix lib/Makefile.am (remove pttype.c)

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: use blkid_new_probe_from_filename() in docs

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add blkid_new_probe_from_filename()

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add support for SBMAGIC and SBMAGIC_OFFSET

Signed-off-by: Karel Zak <kzak@redhat.com>

mkfs.cramfs: fix gcc warning (incompatible pointer type)

mkfs.cramfs.c: In function ‘parse_directory’:
mkfs.cramfs.c:310: warning: passing argument 4 of ‘scandir’ from incompatible pointer type

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: fix gcc warning (warn_unused_result)

save.c: In function ‘blkid_flush_cache’:
save.c:146: warning: ignoring return value of ‘link’, declared with
attribute warn_unused_result

Signed-off-by: Karel Zak <kzak@redhat.com>

lib: remove pttype.c

The libblkid library supports partition tables detection now.

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: fix the default cache file path

The blkid_get_cache_filename() can returns BLKID_CONFIG_FILE instead
BLKID_CACHE_FILE. Yeah, pretty stupid typo.

Fortunately, this brown-paper-bag bug is invisible in almost all cases,
because the default path is returned by blkid_read_config().  The bug
can be visible only when blkid_read_config() returns NULL -- it means
on parses or malloc error.

Signed-off-by: Karel Zak <kzak@redhat.com>

mkswap: use libblkid to detect PT

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update TODO

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: don't scan private /dev/.udev directory

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: use fstatat(), improve readdir() usage

 * fix possible memory leak in ubi_probe_all()

 * use dirent->d_type if available (this is tricky, because d_type
   is not supported on all systems and some filesystems returns
   DT_UNKNOWN). The dirent->d_type allows to avoid unnecessary stat()
   calls.

 * use fstatat() if available -- allows to avoid malloc() and
   sprintf("%s/%s", dirname, dirent->d_name)

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: cleanup blkid_probe_set_device()

It does not make sense to use libblkid for anything other than block
devices, char devices (UBI only) and regular files.

Signed-off-by: Karel Zak <kzak@redhat.com>

tests: add UBIFS test image to blkid test suite

Signed-off-by: Corentin Chary <corentincj@iksaif.net>
Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add UBIFS support

Signed-off-by: Corentin Chary <corentincj@iksaif.net>
Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add UBI volume support

Probe UBI volume under /dev (or /devfs, /devices).
ubi_ctrl skip is hardcoded, maybe we should find a
cleaner way to do that. Also change probe.c to handle
char devices.

[kzak@redhat.com: - rebase the patch to the current HEAD]

Signed-off-by: Corentin Chary <corentincj@iksaif.net>
Signed-off-by: Karel Zak <kzak@redhat.com>

blkid: allow to use -s <TAG> for low-level probing (-p mode)

 # blkid -p -s TYPE /dev/sda3
 /dev/sda3: TYPE="swap"

Signed-off-by: Karel Zak <kzak@redhat.com>

tests: add blkid regression tests for ISO9660

Note that Rock-Ridge detection is not supported yet.

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add LVM topology support (for old kernels)

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: minor changes to dm topology code

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: cleanup topology fallback

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: announce Joliet extension

Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

fallocate: new command

The fallocate(1) utility is used to preallocate blocks to a file.

This can be useful for virtual images, database files, testing, etc.
Normally we'd hope that various tools will start using preallocation
internally, but until then such a utility may be useful, and could be
scripted as well.

The original Eric's version is available at:
http://thread.gmane.org/gmane.linux.utilities.util-linux-ng/2490

This version:
 - checks for fallocate glibc function and kernel syscall
 - does not provide a fallback and does not call posix_fallocate()
 - adds long options
 - uses err.h for errro messages
 - adds NLS support
 - cleanups man page

Co-Author: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

mount: document changed semantics of tmpfs size option in mount.8

Linux kernel commit 818db35992c249dc32c1d86daf7d533fb0952f5d fixed a
problem where invoking mount -t tmpfs with a size argument smaler than the
size of one page caused the limits on the size of a tmpfs to not operate.
The commit also caused the number supplied by the size option to be
rounded up to the  nearest page size instead of down.  This alters the man
page to match the behavior of the kernel in this instance.

Signed-off-by: Kevin Granade <kevin.granade@gmail.com>

libblkid: prefer ISO9660 PVD Label to Joliet Label

The old good libvolume_id had the same behavior.

Reported-by: Maxim Levitsky <maximlevitsky@gmail.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: trim tailing whitespace from unicode LABELs

old version:
$ ./blkid -o udev -p iso-joliet.img
ID_FS_LABEL=ThisIsLabel
ID_FS_LABEL_ENC=ThisIsLabel\x20\x20\x20\x20\x20
ID_FS_VERSION=Joliet\x20Extension
ID_FS_TYPE=iso9660
ID_FS_USAGE=filesystem

new version:
$ ./blkid -o udev -p iso-joliet.img
ID_FS_LABEL=ThisIsLabel
ID_FS_LABEL_ENC=ThisIsLabel
ID_FS_VERSION=Joliet\x20Extension
ID_FS_TYPE=iso9660
ID_FS_USAGE=filesystem

Reported-by: Maxim Levitsky <maximlevitsky@gmail.com>
Addresses-Ubuntu-Bug: #432215
Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: fix blkid_probe_set_utf8label() call for Joliet

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: minor changes to samples

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add EVMS topology support (for old kernels)

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add DM topology support (for old kernels)

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add MD topology support (for old kernels)

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: cosmetic change in topology sample

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: fix probing for binary interface

The probing for binary interface has to always start from scratch.

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add private blkid_topology_set_*() functions

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add blkid_driver_has_major()

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: fix blkid_devno_to_wholedisk()

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: allows more probing methods for topology chain

This patch moves the current topology code to the separate sysfs.c
file.

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: minor fix in topology sample

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: fix topology information values

Looks like the topology values returned are being
inflated by x 512, but the kernel reports them in bytes;
no need for the multiplication, just return the value as-is.

With the patch it all matches:

# mdadm -D /dev/md0  | grep Chunk
     Chunk Size : 64K
# cat /sys/devices/virtual/block/md0/queue/minimum_io_size
65536
# blkid/samples/topology /dev/md0
----- NAME=value interface (values: 0):
MINIMUM_IO_SIZE = 65536
OPTIMAL_IO_SIZE = 131072
----- binary interface:
alignment offset : 0
minimum io size  : 65536
optimal io size  : 131072

Signed-off-by: Eric Sandeen <sandeen@redhat.com>

mount: fix mount.8, xfs attr2 is enabled by default

Address-Red-Hat-Bug: #510845
Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add blkid_partition_get_type_string()

.. because for example Mac and GPT don't use numbers, but strings or
UUIDs as partition type identifier.

Signed-off-by: Karel Zak <kzak@redhat.com>

mount: fix reference to samba-client in mount.8

Address-Red-Hat-Bug: #521367
Signed-off-by: Karel Zak <kzak@redhat.com>

po: update POTFILES.in

Signed-off-by: Karel Zak <kzak@redhat.com>

tests: add partitions probing test

Signed-off-by: Karel Zak <kzak@redhat.com>

tests: rename blkid/images to blkid/images-fs

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: gtkdocize (API docs generated by gtk-docs)

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add missing comments

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add mkfs sample

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add partitions sample

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add EFI GPT partitions support

Signed-off-by: Karel Zak <kzak@redhat.com>

lib: add a generic crc32()

This is public domain implementation, based on static crc32_table[].
This implementation is used on may places (libparted, FreeBSD kernel,
PostgreSQL, ...). The Linux kernel uses on-the-fly generated and
allocated tables. That's useless in shared libraries.

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add MINIX partitions support

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add MS-DOS partitions support

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add MAC partitions support

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add SGI partitions support

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add SUN partitions support

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add SOLARIS-X86 partitions support

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add UNIXWARE partitions support

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add BSD partitions support

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add AIX partitions support

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add partitions filter routines

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add partitions parsing support

This patch is large, but not invasive. There is a new code only.

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add samples/topology.c

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add topology support

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add blkid_devno_to_wholedisk()

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: use the new API in whole u-l-ng

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: refresh blkid.{h,sym}

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add generic function for binary data

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: allow to read in sectors

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: allow to change dimension of probing area

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add blkid_probe_get_{size,sectorsize,devno}

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add missing comments to probe.c

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: use chains in blkid_do_{safe,full,}_probe()

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: use chains in prober (de)initialization

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: use private {lookup,get}_value functions

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: remove superblock functions from probe.c

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: use superblock filter functions

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add superblocks filter functions

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: move blkid_known_fstype() to superblocks.c

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add superblocks chain

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add BLKID_SUBLKS_* flags

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add generic filter functions

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add functions for chain tags

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: add chain structs

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: move filter macros to header file

 * move blkid_bmp_* macros to blkidP.h
 * add blkid_bmp_nbytes() -- returns size of bitmap in bytes
 * add blkid_bmp_nwords() -- returns size of bitmap in words
                             (rename from blkid_bmp_size())

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: create a generic blkid_encode_to_utf8()

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: create a generic blkid_unparse_uuid()

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: use superblocks.h

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: move FS/raid stuff to superblocks directory

Signed-off-by: Karel Zak <kzak@redhat.com>

libblkid: fix typo (swsupend -> swsuspend)

Signed-off-by: Karel Zak <kzak@redhat.com>

mount: more explicitly explain 'strictatime' in mount.8

Signed-off-by: Karel Zak <kzak@redhat.com>

sfdisk: dump has to be $LANG insensitive

This stupid bug has been introduced by:

commit add5133f4ad5136aac3ce7627e615d14893d0aeb
Author: Pedro Ribeiro <p.m42.ribeiro@gmail.com>
Date:   Fri Oct 3 08:52:35 2008 +0200
fdisk: several strings without gettext calls

... so it shows that we need to improve our review process... :-(

Address-Red-Hat-Bug: #522718
Signed-off-by: Karel Zak <kzak@redhat.com>

libuuid: remove .UE macro from libuuid man pages.

On some system it produces insertion of "()".
There is missing .UR anyway.

[kzak@redhat.com: - this is u-l-ng bug, we don't use UR+UE macros like the
                    original man pages in e2fsprogs]

Signed-off-by: Milan Broz <mbroz@redhat.com>

docs: README width and language correction

Signed-off-by: Jan Sarenik <jsarenik@redhat.com>

cfdisk: more key alternatives

Signed-off-by: Jan Sarenik <jsarenik@redhat.com>

rtcwake: ignore the tm_isdst field returned from the RTC

Signed-off-by: Paul Fox <pgf@laptop.org>