]> err.no Git - linux-2.6/log
linux-2.6
18 years ago[TG3]: Add 5722 and 5756 support.
Michael Chan [Wed, 27 Sep 2006 23:03:07 +0000 (16:03 -0700)]
[TG3]: Add 5722 and 5756 support.

Add IDs to support 5722 and 5756.

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[TG3]: PHY fixes.
Michael Chan [Wed, 27 Sep 2006 23:02:29 +0000 (16:02 -0700)]
[TG3]: PHY fixes.

Some PHY related fixes:

1. Fix Serdes WoL.
2. Fix loopback test on 10/100 only devices.

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[TG3]: Improve ASF heartbeat.
Michael Chan [Wed, 27 Sep 2006 23:00:40 +0000 (16:00 -0700)]
[TG3]: Improve ASF heartbeat.

Change to a different ASF heartbeat message code to improve
reliability.

There were some reports of unintended resets on real time kernels
where the timer may be slow and cause the heartbeat to be late.
Netpoll will also have the same problem because the timer irq will
be unavailable.

Using the new heartbeat code, the ASF firmware will also check the
ring condition before resetting the chip when the heartbeat is
expiring.

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[TG3]: Improve 5704S autoneg.
Michael Chan [Wed, 27 Sep 2006 22:59:15 +0000 (15:59 -0700)]
[TG3]: Improve 5704S autoneg.

Improve 5704S autoneg logic by using a serdes_counter field to keep
track of the transient states.  This eliminates a 200 msec busy
loop in the code.  Autoneg will take its course without the driver
busy waiting for it to finish.

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[Bluetooth] Support create connection cancel command
Marcel Holtmann [Tue, 26 Sep 2006 07:43:48 +0000 (09:43 +0200)]
[Bluetooth] Support create connection cancel command

In case of non-blocking connects it is possible that the last user
of an ACL link quits before the connection has been fully established.
This will lead to a race condition where the internal state of a
connection is closed, but the actual link has been established and is
active. In case of Bluetooth 1.2 and later devices it is possible to
call create connection cancel to abort the connect. For older devices
the disconnect timer will be used to trigger the needed disconnect.

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
18 years ago[Bluetooth] Read local version information on device init
Marcel Holtmann [Sat, 23 Sep 2006 07:57:20 +0000 (09:57 +0200)]
[Bluetooth] Read local version information on device init

The local version information are needed to identify certain feature
sets of devices. They must be read on device init and stored for later
use. It is also possible to access them through the device model.

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
18 years ago[Bluetooth] Return EINPROGRESS for non-blocking socket calls
Marcel Holtmann [Sat, 23 Sep 2006 07:54:38 +0000 (09:54 +0200)]
[Bluetooth] Return EINPROGRESS for non-blocking socket calls

In case of non-blocking socket calls we should return EINPROGRESS
and not EAGAIN.

Signed-off-by: Ulisses Furquim <ulissesf@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
18 years ago[Bluetooth] Code cleanup for the HCI UART driver
Marcel Holtmann [Thu, 21 Sep 2006 14:23:19 +0000 (16:23 +0200)]
[Bluetooth] Code cleanup for the HCI UART driver

This patch cleans up the Bluetooth HCI UART driver a bit.

Signed-off-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
18 years ago[Bluetooth] Add support for Canyon CN-BTU1 dongle
Marcel Holtmann [Thu, 21 Sep 2006 14:19:55 +0000 (16:19 +0200)]
[Bluetooth] Add support for Canyon CN-BTU1 dongle

This patch adds the vendor and product id of the Canycon CN-BTU1
dongle and sets a flag to send HCI_Reset as the first command.

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
18 years ago[Bluetooth] Handle command complete event for exit periodic inquiry
Marcel Holtmann [Thu, 21 Sep 2006 14:04:00 +0000 (16:04 +0200)]
[Bluetooth] Handle command complete event for exit periodic inquiry

The command complete event of the exit periodic inquiry command must
clear the HCI_INQUIRY flag and finish the HCI request.

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
18 years ago[Bluetooth] Add HCI device identifier for SDIO cards
Marcel Holtmann [Sat, 8 Jul 2006 11:57:15 +0000 (13:57 +0200)]
[Bluetooth] Add HCI device identifier for SDIO cards

This patch assigns the next free HCI device identifier to Bluetooth
devices based on the SDIO interface.

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
18 years ago[Bluetooth] Code cleanup of the drivers source code
Marcel Holtmann [Thu, 6 Jul 2006 13:45:23 +0000 (15:45 +0200)]
[Bluetooth] Code cleanup of the drivers source code

This patch is an attempt to cleanup the drivers source code to make all
Bluetooth drivers look more unique.

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
18 years ago[Bluetooth] Integrate services into the driver model
Marcel Holtmann [Thu, 6 Jul 2006 11:09:02 +0000 (13:09 +0200)]
[Bluetooth] Integrate services into the driver model

This patch integrates the services of the Bluetooth protocols RFCOMM,
BNEP and HIDP into the driver model. This makes it possible to assign
the virtual TTY, network and input devices to a specific Bluetooth
connection.

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
18 years ago[Bluetooth] Integrate low-level connections into the driver model
Marcel Holtmann [Thu, 6 Jul 2006 10:38:46 +0000 (12:38 +0200)]
[Bluetooth] Integrate low-level connections into the driver model

This patch integrates the low-level connections (ACL and SCO) into the
driver model. Every connection is presented as device with the parent
set to its host controller device.

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
18 years ago[Bluetooth] Remove unused host controller attributes
Marcel Holtmann [Thu, 6 Jul 2006 10:34:41 +0000 (12:34 +0200)]
[Bluetooth] Remove unused host controller attributes

This patch removes the unused device attribute entries for the Bluetooth
host controllers.

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
18 years ago[RTNETLINK]: Possible dereference in net/core/rtnetlink.c
Eric Sesterhenn [Wed, 27 Sep 2006 06:26:38 +0000 (23:26 -0700)]
[RTNETLINK]: Possible dereference in net/core/rtnetlink.c

another possible dereference spotted by coverity (#cid 1390).
if the nlmsg_parse() call fails, we goto errout, where we call
dev_put(), with dev still initialized to NULL.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[SUNRPC]: more sunrpc endianness annotations
Al Viro [Wed, 27 Sep 2006 05:30:23 +0000 (22:30 -0700)]
[SUNRPC]: more sunrpc endianness annotations

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[SUNRPC]: trivial endianness annotations
Alexey Dobriyan [Wed, 27 Sep 2006 05:29:38 +0000 (22:29 -0700)]
[SUNRPC]: trivial endianness annotations

pure s/u32/__be32/

[AV: large part based on Alexey's patches]

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[SUNRPC]: svc_{get,put}nl()
Alexey Dobriyan [Wed, 27 Sep 2006 05:28:46 +0000 (22:28 -0700)]
[SUNRPC]: svc_{get,put}nl()

* add svc_getnl():
Take network-endian value from buffer, convert to host-endian
and return it.
* add svc_putnl():
Take host-endian value, convert to network-endian and put it
into a buffer.
* annotate svc_getu32()/svc_putu32() as dealing with network-endian.
* convert to svc_getnl(), svc_putnl().

[AV: in large part it's a carved-up Alexey's patch]

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: ip_build_and_send_pkt() annotations
Al Viro [Wed, 27 Sep 2006 05:27:30 +0000 (22:27 -0700)]
[IPV4]: ip_build_and_send_pkt() annotations

saddr and daddr are net-endian

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: ip_options_build() annotations
Al Viro [Wed, 27 Sep 2006 05:27:05 +0000 (22:27 -0700)]
[IPV4]: ip_options_build() annotations

daddr is net-endian

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4] bug: broken open-coded inet_make_mask() (multipath_wrandom)
Al Viro [Wed, 27 Sep 2006 05:26:21 +0000 (22:26 -0700)]
[IPV4] bug: broken open-coded inet_make_mask() (multipath_wrandom)

multipath_wrandom.c::__multipath_lookup_weight() contains open-coded
attempt at inet_make_mask(); broken on big-endian.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4] multipath_wrandom.c: trivial annotations
Al Viro [Wed, 27 Sep 2006 05:25:13 +0000 (22:25 -0700)]
[IPV4] multipath_wrandom.c: trivial annotations

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: multipath_set_nhinfo() annotations
Al Viro [Wed, 27 Sep 2006 05:22:50 +0000 (22:22 -0700)]
[IPV4]: multipath_set_nhinfo() annotations

multipath_set_nhinfo() (and underlying callback) take net-endian
network and netmask.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4] fib_trie.c: trivial annotations
Al Viro [Wed, 27 Sep 2006 05:21:45 +0000 (22:21 -0700)]
[IPV4] fib_trie.c: trivial annotations

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4] bug: open-coded inet_make_mask() in fib_semantic_match() is broken
Al Viro [Wed, 27 Sep 2006 05:21:22 +0000 (22:21 -0700)]
[IPV4] bug: open-coded inet_make_mask() in fib_semantic_match() is broken

... and works only on little-endian

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: fib_semantic_match() annotations
Al Viro [Wed, 27 Sep 2006 05:20:56 +0000 (22:20 -0700)]
[IPV4]: fib_semantic_match() annotations

'mask' and 'zone' arguments are net-endian

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: trivial fib_hash.c annotations
Al Viro [Wed, 27 Sep 2006 05:20:01 +0000 (22:20 -0700)]
[IPV4]: trivial fib_hash.c annotations

hash key and stored netmask are net-endian

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: annotate addresses in fib_result and fib_result_nl
Al Viro [Wed, 27 Sep 2006 05:19:36 +0000 (22:19 -0700)]
[IPV4]: annotate addresses in fib_result and fib_result_nl

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: ip_fragment.c endianness annotations
Al Viro [Wed, 27 Sep 2006 05:19:02 +0000 (22:19 -0700)]
[IPV4]: ip_fragment.c endianness annotations

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: inetpeer annotations
Al Viro [Wed, 27 Sep 2006 05:18:43 +0000 (22:18 -0700)]
[IPV4]: inetpeer annotations

This one is interesting - we use net-endian value as search key, but
order the tree by *host-endian* comparisons of keys.  OK since we only
care about lookups.  Annotated inet_getpeer() and friends.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: ip_fib_check_default() annotated
Al Viro [Wed, 27 Sep 2006 05:18:13 +0000 (22:18 -0700)]
[IPV4]: ip_fib_check_default() annotated

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: inet_addr_type() annotations
Al Viro [Wed, 27 Sep 2006 05:17:51 +0000 (22:17 -0700)]
[IPV4]: inet_addr_type() annotations

argument and inferred net-endian variables in callers annotated.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: icmp_send() annotation
Al Viro [Wed, 27 Sep 2006 05:17:28 +0000 (22:17 -0700)]
[IPV4]: icmp_send() annotation

The last argument is network-endian (it will go straight into the packet).

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: annotate inetdev.h helpers
Al Viro [Wed, 27 Sep 2006 05:17:09 +0000 (22:17 -0700)]
[IPV4]: annotate inetdev.h helpers

inet_confirm_addr(), inet_ifa_byprefix(), ip_dev_find(), inet_make_mask() and
inet_ifa_match() annotated, along with inferred net-endian variables

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: IFA_{LOCAL,ADDRESS,BROADCAST,ANYCAST} on ipv4 annotated
Al Viro [Wed, 27 Sep 2006 05:16:43 +0000 (22:16 -0700)]
[IPV4]: IFA_{LOCAL,ADDRESS,BROADCAST,ANYCAST} on ipv4 annotated

use be32 netlink accessors

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: annotate struct in_ifaddr
Al Viro [Fri, 29 Sep 2006 01:00:55 +0000 (18:00 -0700)]
[IPV4]: annotate struct in_ifaddr

ifa_local, ifa_address, ifa_mask, ifa_broadcast and ifa_anycast are
net-endian.  Annotated them and variables that are inferred to be
net-endian.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: struct fib_config IPv4 address fields annotated
Al Viro [Wed, 27 Sep 2006 05:15:46 +0000 (22:15 -0700)]
[IPV4]: struct fib_config IPv4 address fields annotated

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: RTA_{DST,SRC,GATEWAY,PREFSRC} annotated
Al Viro [Wed, 27 Sep 2006 05:15:25 +0000 (22:15 -0700)]
[IPV4]: RTA_{DST,SRC,GATEWAY,PREFSRC} annotated

these are passed net-endian; use be32 netlink accessors

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4] net/ipv4/route.c: trivial endianness annotations
Al Viro [Wed, 27 Sep 2006 05:15:01 +0000 (22:15 -0700)]
[IPV4] net/ipv4/route.c: trivial endianness annotations

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: introduce nla_get_be32()/NLA_PUT_BE32()
Al Viro [Wed, 27 Sep 2006 05:14:41 +0000 (22:14 -0700)]
[IPV4]: introduce nla_get_be32()/NLA_PUT_BE32()

net-endian counterparts of nla_get_u32()/NLA_PUT_U32()

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: FIB_RES_PREFSRC() annotated
Al Viro [Wed, 27 Sep 2006 05:14:15 +0000 (22:14 -0700)]
[IPV4]: FIB_RES_PREFSRC() annotated

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: fib_hn ->nh_gw is net-endian
Al Viro [Wed, 27 Sep 2006 05:13:54 +0000 (22:13 -0700)]
[IPV4]: fib_hn ->nh_gw is net-endian

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: inet_addr_onlink() annotated
Al Viro [Wed, 27 Sep 2006 05:13:35 +0000 (22:13 -0700)]
[IPV4]: inet_addr_onlink() annotated

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: ip_check_mc() annotations
Al Viro [Wed, 27 Sep 2006 04:28:34 +0000 (21:28 -0700)]
[IPV4]: ip_check_mc() annotations

annotated arguments

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: fib_validate_source() annotations
Al Viro [Wed, 27 Sep 2006 04:28:14 +0000 (21:28 -0700)]
[IPV4]: fib_validate_source() annotations

annotated arguments and inferred net-endian variables in callers

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: inet_select_addr() annotations
Al Viro [Wed, 27 Sep 2006 04:27:54 +0000 (21:27 -0700)]
[IPV4]: inet_select_addr() annotations

argument and return value are net-endian.  Annotated function and inferred
net-endian variables in callers.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: annotated ipv4 addresses in struct inet_sock
Al Viro [Wed, 27 Sep 2006 04:27:35 +0000 (21:27 -0700)]
[IPV4]: annotated ipv4 addresses in struct inet_sock

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: ip_route_connect() ipv4 address arguments annotated
Al Viro [Wed, 27 Sep 2006 04:27:15 +0000 (21:27 -0700)]
[IPV4]: ip_route_connect() ipv4 address arguments annotated

annotated address arguments (port number left alone for now); ditto
for inferred net-endian variables in callers.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: annotate ipv4 addresses in struct rtable and struct flowi
Al Viro [Wed, 27 Sep 2006 04:26:42 +0000 (21:26 -0700)]
[IPV4]: annotate ipv4 addresses in struct rtable and struct flowi

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: annotate rt_hash_code() users
Al Viro [Wed, 27 Sep 2006 04:26:19 +0000 (21:26 -0700)]
[IPV4]: annotate rt_hash_code() users

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: ip_rt_redirect() annotations
Al Viro [Wed, 27 Sep 2006 04:25:43 +0000 (21:25 -0700)]
[IPV4]: ip_rt_redirect() annotations

The first 4 arguments of ip_rt_redirect() are net-endian.  Annotated.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: ip_route_input() annotations
Al Viro [Wed, 27 Sep 2006 04:25:20 +0000 (21:25 -0700)]
[IPV4]: ip_route_input() annotations

ip_route_input() takes net-endian source and destination address.
* Annotated as such.
* arguments of its invocations annotated where needed.
* local helpers getting the same values passed to by it (ip_route_input_mc(),
ip_route_input_slow(), ip_handle_martian_source(), ip_mkroute_input(),
ip_mkroute_input_def(), __mkroute_input()) annotated

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV4]: headers endianness
Al Viro [Wed, 27 Sep 2006 04:24:24 +0000 (21:24 -0700)]
[IPV4]: headers endianness

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[ATM]: use NIPQUAD instead of open-coding it
Al Viro [Wed, 27 Sep 2006 04:23:43 +0000 (21:23 -0700)]
[ATM]: use NIPQUAD instead of open-coding it

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[TR]: endiannness annotations
Al Viro [Wed, 27 Sep 2006 04:23:16 +0000 (21:23 -0700)]
[TR]: endiannness annotations

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[ATALK]: endianness annotations
Al Viro [Wed, 27 Sep 2006 04:22:08 +0000 (21:22 -0700)]
[ATALK]: endianness annotations

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[NET] Kconfig: fix cut/paste error in TCPPROBE
Grant Grundler [Tue, 26 Sep 2006 06:47:14 +0000 (23:47 -0700)]
[NET] Kconfig: fix cut/paste error in TCPPROBE

Fix cut/paste error in TCPPROBE help text.

Signed-off-by: Grant Grundler <grundler@parisc-linux.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[NETDEV] config: revert part of previous patch
Randy Dunlap [Tue, 26 Sep 2006 06:11:21 +0000 (23:11 -0700)]
[NETDEV] config: revert part of previous patch

Net devices should depend on NETDEVICES, so revert part of
Paolo's previous patch.

See http://marc.theaimsgroup.com/?l=linux-kernel&m=115566326218740&w=2
for history.

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IRDA] via-ircc: fix memory leak
Chuck Short [Tue, 26 Sep 2006 05:31:03 +0000 (22:31 -0700)]
[IRDA] via-ircc: fix memory leak

Fix memory leak.

Coverity id# 653

patch location:
http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commitdiff;h=a1f34cb68b16807ed9d5ebb0f6a6ec5ff8a5fc78

Signed-off-by: Chuck Short <zulcss@gmail.com>
Signed-off-by: Ben Collins <bcollins@ubuntu.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years ago[IPV6]: bh_lock_sock_nested on tcp_v6_rcv
Fabio Olive Leite [Tue, 26 Sep 2006 05:28:47 +0000 (22:28 -0700)]
[IPV6]: bh_lock_sock_nested on tcp_v6_rcv

A while ago Ingo patched tcp_v4_rcv on net/ipv4/tcp_ipv4.c to use
bh_lock_sock_nested and silence a lock validator warning. This fixed
it for IPv4, but recently I saw a report of the same warning on IPv6.

Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
18 years agoMerge master.kernel.org:/pub/scm/linux/kernel/git/gregkh/hwmon-2.6
Linus Torvalds [Thu, 28 Sep 2006 23:23:27 +0000 (16:23 -0700)]
Merge master.kernel.org:/pub/scm/linux/kernel/git/gregkh/hwmon-2.6

* master.kernel.org:/pub/scm/linux/kernel/git/gregkh/hwmon-2.6: (39 commits)
  hwmon: Remove Yuan Mu's address
  hwmon: Fix unchecked return status, SMSC chips
  hwmon: Fix unchecked return status, batch 6
  w83792d: Fix unchecked return status
  w83l785ts: Fix unchecked return status
  w83781d: Fix unchecked return status
  vt8231: Fix unchecked return status
  Fix unchecked return status, batch 5
  hwmon: Fix unchecked return status, batch 4
  hwmon: Fix unchecked return status, batch 3
  hwmon: Fix unchecked return status, batch 2
  w83627ehf: Fix unchecked return status
  pc87360: Check for error on sysfs files creation
  pc87360: Delete sysfs files on device deletion
  pc87360: Move some code around
  hwmon: Fix unchecked return status, batch 1
  vt1211: Document module parameters
  vt1211: Add documentation
  hwmon: New driver for the VIA VT1211
  w83791d: Documentation update
  ...

18 years agoUSB: g_file_storage: Set sense info Valid bit only when needed
Alan Stern [Tue, 26 Sep 2006 18:51:48 +0000 (14:51 -0400)]
USB: g_file_storage: Set sense info Valid bit only when needed

Strictly speaking, the Valid bit in SCSI sense data is supposed to
be set only when the Information field contains a valid number.  This
patch (as793) turns off the Valid bit when the Information field
hasn't been set.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agoUSB: fix autosuspend when CONFIG_PM isn't set
Alan Stern [Tue, 26 Sep 2006 18:50:20 +0000 (14:50 -0400)]
USB: fix autosuspend when CONFIG_PM isn't set

This patch (as791b) fixes things up to avoid compiler warnings or
errors when CONFIG_USB_SUSPEND or CONFIG_PM isn't set.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agoOHCI: add auto-stop support
Alan Stern [Tue, 26 Sep 2006 18:46:16 +0000 (14:46 -0400)]
OHCI: add auto-stop support

This patch (as790b) adds "autostop" support to ohci-hcd: the driver
will automatically stop the host controller when no devices have been
connected for at least one second.  This feature is useful when the
USB autosuspend facility isn't available, such as when
CONFIG_USB_SUSPEND hasn't been set.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agoOHCI: remove existing autosuspend code
Alan Stern [Mon, 25 Sep 2006 19:41:21 +0000 (15:41 -0400)]
OHCI: remove existing autosuspend code

The autosuspend technique used by ohci-hcd doesn't mesh well with the
newer USB core autosuspend code.  This patch (as789) removes ohci-hcd's
autosuspend support.  Now the driver will be usable, but it won't
automatically go into a low-power state when no devices are connected.
That's for a later patch.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agoUSB: allow both root-hub interrupts and polling
Alan Stern [Mon, 25 Sep 2006 19:41:12 +0000 (15:41 -0400)]
USB: allow both root-hub interrupts and polling

Originally I didn't think any host controller driver would ever use
interrupts and polling at the same time, but it turns out ohci-hcd wants
to do exactly that.  This patch (as788) makes it possible.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agoUSB: g_file_storage: fix "ignoring return value" warnings
Alan Stern [Mon, 25 Sep 2006 18:31:15 +0000 (14:31 -0400)]
USB: g_file_storage: fix "ignoring return value" warnings

This patch (as792) fixes "ignoring return value" warnings in
file_storage.c.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agoUSB: dummy-hcd: fix "warn-unused-result" messages
Alan Stern [Mon, 25 Sep 2006 15:55:56 +0000 (11:55 -0400)]
USB: dummy-hcd: fix "warn-unused-result" messages

This patch (as758) fixes the "warn-unused-result" messages in dummy-hcd.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agoUSB: create new workqueue thread for USB autosuspend
Alan Stern [Tue, 19 Sep 2006 14:14:07 +0000 (10:14 -0400)]
USB: create new workqueue thread for USB autosuspend

This patch (as787) creates a new workqueue thread to handle delayed
USB autosuspend requests.  Previously the code used keventd.  However
it turns out that the hub driver's suspend routine calls
flush_scheduled_work(), making it a poor candidate for running in
keventd (the call immediately deadlocks).  The solution is to use a
new thread instead of keventd.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agoUSB Storage: unusual_devs.h entry for Sony Ericsson P990i
Jan Mate [Tue, 26 Sep 2006 00:00:57 +0000 (17:00 -0700)]
USB Storage: unusual_devs.h entry for Sony Ericsson P990i

USB Storage: this patch adds support for Sony Ericsson P990i

Signed-off-by: Jan Mate <mate@fiit.stuba.sk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agoUSB: microtek usb scanner: Scsi_Cmnd conversion
Henrik Kretzschmar [Tue, 26 Sep 2006 00:00:58 +0000 (17:00 -0700)]
USB: microtek usb scanner: Scsi_Cmnd conversion

Converts obsolete typedef'd Scsi_Cmnd into struct scsi_cmnd.

Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
Cc: James Bottomley <James.Bottomley@steeleye.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agoUSB: fixes kerneldoc errors in usbcore-auto(susp/res)-patch
Henrik Kretzschmar [Tue, 26 Sep 2006 00:00:56 +0000 (17:00 -0700)]
USB: fixes kerneldoc errors in usbcore-auto(susp/res)-patch

Fixes kerneldoc errors on usb/core/driver.c, which occured in 2.6.18-rc6-mm2
gregkh-usb-usbcore-add-autosuspend-autoresume-infrastructure.patch

Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agoUSB: add Raritan KVM USB Dongle to the HID_QUIRK_NOGET blacklist
Raghavendra Biligiri [Fri, 15 Sep 2006 14:23:35 +0000 (19:53 +0530)]
USB: add Raritan KVM USB Dongle to the HID_QUIRK_NOGET blacklist

During Installation the host tries to enumerate the keyboard/mouse
dongle for the Raritan KVM.At this time timeouts have been observed
Adding the Raritan KVM USB dongle to the blacklist fixes this issue.

Signed-off-by: Raghavendra Biligiri <Raghavendra_Biligiri@Dell.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agoUSB: asix - Add alternate device IDs for Dlink DUB-E100 Rev B1
David Hollis [Thu, 21 Sep 2006 12:09:29 +0000 (08:09 -0400)]
USB: asix - Add alternate device IDs for Dlink DUB-E100 Rev B1

Add alternate device IDs for Dlink DUB-E100 Rev B1

Signed-off-by: David Hollis <dhollis@davehollis.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agousb-serial: possible irq lock inversion (PPP vs. usb/serial)
Peter Zijlstra [Mon, 25 Sep 2006 10:51:41 +0000 (12:51 +0200)]
usb-serial: possible irq lock inversion (PPP vs. usb/serial)

=========================================================
[ INFO: possible irq lock inversion dependency detected ]

18 years agoohci: Use ref-counting hotplug safe interfaces
Alan Cox [Wed, 27 Sep 2006 22:43:22 +0000 (15:43 -0700)]
ohci: Use ref-counting hotplug safe interfaces

We want to avoid legacy APIs like pci_find_slot().

Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agoUSB: Fix alignment of buffer passed down to ->hub_control()
Mikael Pettersson [Sun, 24 Sep 2006 00:05:31 +0000 (17:05 -0700)]
USB: Fix alignment of buffer passed down to ->hub_control()

Implementations assume the buffer is at least 4 byte aligned.

Signed-off-by: David S. Miller <davem@davemloft.net>
Cc: David Brownell <david-b@pacbell.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agoUSB: add SeaLevel 2106 SeaLINK support to ftdi_sio
Justin Carlson [Sun, 24 Sep 2006 08:52:12 +0000 (11:52 +0300)]
USB: add SeaLevel 2106 SeaLINK support to ftdi_sio

We have a couple of these USB-Serial converters around; they're slightly
different from the 2104 models in that they can handle 500Kb/sec over RS422.
The existing ftdi driver seems to work just fine if we add in the
appropriate IDs.

Patch is against 2.6.17.6, but should apply cleanly to pretty much
anything recent.

From: Justin Carlson <justinca@qatar.cmu.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agoUSB: New PhidgetKit 8/8/8 reset outputs after 2 seconds
Sean Young [Sun, 24 Sep 2006 19:26:57 +0000 (19:26 +0000)]
USB: New PhidgetKit 8/8/8 reset outputs after 2 seconds

New phidget interface kits (type 8/8/8) reset their outputs if they
haven't received a set report for 2 seconds.

Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agoUSB: another device ID for ipaq
Matthias Urlichs [Sun, 24 Sep 2006 19:38:47 +0000 (21:38 +0200)]
USB: another device ID for ipaq

Add yet another device ID to the ipaq USB-serial driver.

Signed-Off-By: Matthias Urlichs <matthias@urlichs.de>
Cc: Ganesh Varadarajan <ganesh@veritas.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agoUSB serial ftdi_sio: Add support for Tactrix OpenPort devices
Ian Abbott [Mon, 25 Sep 2006 13:19:19 +0000 (14:19 +0100)]
USB serial ftdi_sio: Add support for Tactrix OpenPort devices

This patch adds support for three OpenPort ECU data cables from Tactrix
Inc. to the ftdi_sio driver's device ID table.  One of the PIDs was
supplied by Donour Sizemore on the ftdi-usb-sio-devel mailing list.  The
other two were added by myself after examining the Windows driver software.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agoUSB: Pegasus driver failing for ADMtek 8515 network device
Petko Manolov [Wed, 27 Sep 2006 21:25:37 +0000 (14:25 -0700)]
USB: Pegasus driver failing for ADMtek 8515 network device

Address http://bugzilla.kernel.org/show_bug.cgi?id=7126

Attempting to read the ethernet ID directly from the eeprom somehow
confuses ADM8515.  Subsequent read requests to either the eeprom or the MII
fail as well.  Didn't dig much deeper, though.  For example ADM8513 does
not experience this problem.

I used the fact that at power up the device is reading its ID automatically
(not true for older Pegasus based devices) and put it in the Ethernet ID
registers.  So now the driver uses get_registers() instead of
read_eprom_word() if the device is Pegasus_II based one.  Tested it with
all (Pegasus and Pegasus_II) gadgets i have and everything seems ok.

Cc: <jogeedaklown@yahoo.com>
Cc: David Brownell <david-b@pacbell.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agoUSB: unusual-devs entry for Nokia E60
Alan Stern [Thu, 28 Sep 2006 16:11:56 +0000 (12:11 -0400)]
USB: unusual-devs entry for Nokia E60

This patch (as794) adds an unusual_devs entry for the Nokia E60.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agoUSB: Add vendor / product ID to pl2303
Wesley PA4WDH [Thu, 28 Sep 2006 18:45:38 +0000 (20:45 +0200)]
USB: Add vendor / product ID to pl2303

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agoUSB: new id for kaweth
Oliver Neukum [Thu, 28 Sep 2006 20:21:19 +0000 (22:21 +0200)]
USB: new id for kaweth

this adds a new id to the kaweth driver.
Please apply.

Signed-Off-By: Oliver Neukum <oliver@neukum.name>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agohwmon: Remove Yuan Mu's address
Jean Delvare [Sun, 24 Sep 2006 19:25:52 +0000 (21:25 +0200)]
hwmon: Remove Yuan Mu's address

hwmon: Remove Yuan Mu's address

Yuan Mu no longer works at Winbond.

I wish to publicly thank Yuan for his help with Winbond hardware
monitoring chips support during the past 10 months.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agohwmon: Fix unchecked return status, SMSC chips
Jean Delvare [Sun, 24 Sep 2006 19:25:12 +0000 (21:25 +0200)]
hwmon: Fix unchecked return status, SMSC chips

hwmon: Fix unchecked return status, SMSC chips

Fix up 2 more hwmon drivers so that they no longer ignore return
status from device_create_file().

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agohwmon: Fix unchecked return status, batch 6
Jean Delvare [Sun, 24 Sep 2006 19:24:46 +0000 (21:24 +0200)]
hwmon: Fix unchecked return status, batch 6

hwmon: Fix unchecked return status, batch 6

Fix up 5 more hwmon drivers so that they no longer ignore return status
from device_create_file().

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agow83792d: Fix unchecked return status
Rudolf Marek [Sun, 24 Sep 2006 19:24:12 +0000 (21:24 +0200)]
w83792d: Fix unchecked return status

w83792d: Fix unchecked return status

Fix the w83792d driver. Add error checking to device_create_file
and also care to destroy the files upon exit.

Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agow83l785ts: Fix unchecked return status
Rudolf Marek [Sun, 24 Sep 2006 19:23:26 +0000 (21:23 +0200)]
w83l785ts: Fix unchecked return status

w83l785ts: Fix unchecked return status

Fix the w83l785ts driver. Add error checking to device_create_file
and also care to destroy the files upon exit.

Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agow83781d: Fix unchecked return status
Jim Cromie [Sun, 24 Sep 2006 19:22:52 +0000 (21:22 +0200)]
w83781d: Fix unchecked return status

w83781d: Fix unchecked return status

Add 2 attr-file groups (for base and model-specific attrs respectively),
create the base group with single call to sysfs_create_group,
check the return code on individual calls to device_create_file for each
of the model-specific attr-files.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agovt8231: Fix unchecked return status
Roger Lucas [Sun, 24 Sep 2006 19:21:46 +0000 (21:21 +0200)]
vt8231: Fix unchecked return status

vt8231: Fix unchecked return status

Check the return status from device_create_file() and also use
the newer and cleaner sysfs creation functions.

Signed-off-by: Roger Lucas <roger@planbit.co.uk>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agoFix unchecked return status, batch 5
Jean Delvare [Sun, 24 Sep 2006 19:17:13 +0000 (21:17 +0200)]
Fix unchecked return status, batch 5

hwmon: Fix unchecked return status, batch 5

Fix up some hwmon drivers so that they no longer ignore return status
from device_create_file().

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agohwmon: Fix unchecked return status, batch 4
Jean Delvare [Sun, 24 Sep 2006 19:16:40 +0000 (21:16 +0200)]
hwmon: Fix unchecked return status, batch 4

hwmon: Fix unchecked return status, batch 4

Fix up some hwmon drivers so that they no longer ignore return status
from device_create_file().

Note: f71805f actually checked the status from device_create_file
already. However it did not remove the files on device destruction.
It was also an opportunity to use sysfs_create/remove_group instead
of hand-made loops. This makes the changes much more important but
I think the result is worth it.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agohwmon: Fix unchecked return status, batch 3
Mark M. Hoffman [Sun, 24 Sep 2006 19:15:35 +0000 (21:15 +0200)]
hwmon: Fix unchecked return status, batch 3

hwmon: Fix unchecked return status, batch 3

Fix up some hwmon drivers so that they no longer ignore return status
from device_create_file().

Signed-off-by: Mark M. Hoffman <mhoffman@lightlink.com>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agohwmon: Fix unchecked return status, batch 2
Mark M. Hoffman [Sun, 24 Sep 2006 19:14:35 +0000 (21:14 +0200)]
hwmon: Fix unchecked return status, batch 2

hwmon: Fix unchecked return status, batch 2

Fix up some hwmon drivers so that they no longer ignore return status
from device_create_file().

Signed-off-by: Mark M. Hoffman <mhoffman@lightlink.com>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agow83627ehf: Fix unchecked return status
David Hubbard [Sun, 24 Sep 2006 19:04:38 +0000 (21:04 +0200)]
w83627ehf: Fix unchecked return status

w83627ehf: Fix unchecked return status

Fix: check return value from device_create_file()
Fix: call device_remove_file() on error and module unload
Fix: call hwmon_device_register() after device_create_file() to eliminate race

Signed-off-by: David Hubbard <david.c.hubbard@gmail.com>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agopc87360: Check for error on sysfs files creation
Jim Cromie [Sun, 24 Sep 2006 19:03:25 +0000 (21:03 +0200)]
pc87360: Check for error on sysfs files creation

pc87360: Check for error on sysfs files creation

Use sysfs_create_group() for 2 sensor-types which are chip-model
invariant, i.e. all-or-nothing attribute groups.
Other 2 groups vary too much due to configuration, etc, so we keep the
loops of device_create_file(), but now check their returns.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
18 years agopc87360: Delete sysfs files on device deletion
Jim Cromie [Sun, 24 Sep 2006 19:02:44 +0000 (21:02 +0200)]
pc87360: Delete sysfs files on device deletion

pc87360: Delete sysfs files on device deletion

Add 4 explicit attribute groups for the 5 sensor types:
voltage (in), therm, temp, and fan & pwm (together in one group).
Use sysfs_remove_group() to drop them, but keeps the existing
startup code, which calls device_create_file in loops.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>