From: Mauro Carvalho Chehab <mchehab@infradead.org>
Date: Sat, 14 Apr 2007 18:17:35 +0000 (-0300)
Subject: V4L/DVB (5518): Fix a bug on device detection
X-Git-Tag: v2.6.22-rc1~1118^2~36
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f8a389db502f7b287903b209f925df5570ff5478;p=linux-2.6

V4L/DVB (5518): Fix a bug on device detection

Thanks to: Thierry MERLE <thierry.merle@free.fr> for pointing this

Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
---

diff --git a/drivers/media/video/usbvision/usbvision-cards.c b/drivers/media/video/usbvision/usbvision-cards.c
index c632f12525..edee094cf1 100644
--- a/drivers/media/video/usbvision/usbvision-cards.c
+++ b/drivers/media/video/usbvision/usbvision-cards.c
@@ -1027,6 +1027,7 @@ struct usbvision_device_data_st  usbvision_device_data[] = {
 		.ModelString   = "Hauppauge WinTv-USB",
 	},
 };
+const int usbvision_device_data_size=ARRAY_SIZE(usbvision_device_data);
 
 /* Supported Devices */
 
diff --git a/drivers/media/video/usbvision/usbvision-cards.h b/drivers/media/video/usbvision/usbvision-cards.h
index 37d619b1e0..766accc927 100644
--- a/drivers/media/video/usbvision/usbvision-cards.h
+++ b/drivers/media/video/usbvision/usbvision-cards.h
@@ -63,3 +63,5 @@
 #define PINNA_LINX_VD_IN_CAB_PAL                 62
 #define PINNA_PCTV_BUNGEE_PAL_FM                 63
 #define HPG_WINTV                                64
+
+extern const int usbvision_device_data_size;
diff --git a/drivers/media/video/usbvision/usbvision-video.c b/drivers/media/video/usbvision/usbvision-video.c
index aa6509391b..df030bf84c 100644
--- a/drivers/media/video/usbvision/usbvision-video.c
+++ b/drivers/media/video/usbvision/usbvision-video.c
@@ -1792,6 +1792,10 @@ static int __devinit usbvision_probe(struct usb_interface *intf,
 				dev->descriptor.idProduct, ifnum);
 
 	model = devid->driver_info;
+	if ( (model<0) || (model>=usbvision_device_data_size) ) {
+		printk(KERN_INFO "model out of bounds %d\n",model);
+		return -ENODEV;
+	}
 	printk(KERN_INFO "%s: %s found\n", __FUNCTION__,
 				usbvision_device_data[model].ModelString);