From: Adrian Bunk <bunk@kernel.org>
Date: Tue, 2 Oct 2007 21:38:09 +0000 (-0700)
Subject: [SCSI] imm: fix check-after-use
X-Git-Tag: v2.6.24-rc1~1290^2~24
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f01f9d59433dd9d244664c19771e078a194e7984;p=linux-2.6

[SCSI] imm: fix check-after-use

The Coverity checker spotted that we have already oops'ed if "cmd"
was NULL.

Since "cmd" being NULL doesn't seem to be possible at this point this
patch removes the NULL check.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
---

diff --git a/drivers/scsi/imm.c b/drivers/scsi/imm.c
index 005d2b05f3..74cdc1f0a7 100644
--- a/drivers/scsi/imm.c
+++ b/drivers/scsi/imm.c
@@ -740,10 +740,6 @@ static void imm_interrupt(struct work_struct *work)
 	struct Scsi_Host *host = cmd->device->host;
 	unsigned long flags;
 
-	if (!cmd) {
-		printk("IMM: bug in imm_interrupt\n");
-		return;
-	}
 	if (imm_engine(dev, cmd)) {
 		schedule_delayed_work(&dev->imm_tq, 1);
 		return;