From: Jesper Juhl <jesper.juhl@gmail.com>
Date: Mon, 17 Apr 2006 02:02:54 +0000 (+0200)
Subject: [PATCH] PCI: fix potential resource leak in drivers/pci/msi.c
X-Git-Tag: v2.6.17-rc4~136^2~1
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f01f4182597a3bb4b6fbf92e041faf7a1016f4b6;p=linux-2.6

[PATCH] PCI: fix potential resource leak in drivers/pci/msi.c

The coverity checker spotted (as entry #599) that we might leak `entry' in
drivers/pci/msi.c::msix_capability_init()
This patch should take care of that.

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index 2087a397ef..9855c4c920 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -793,8 +793,10 @@ static int msix_capability_init(struct pci_dev *dev,
 		if (!entry)
 			break;
 		vector = get_msi_vector(dev);
-		if (vector < 0)
+		if (vector < 0) {
+			kmem_cache_free(msi_cachep, entry);
 			break;
+		}
 
  		j = entries[i].entry;
  		entries[i].vector = vector;