From: Emmanuel Rodriguez <emmanuel.rodriguez@gmail.com>
Date: Sat, 11 Jul 2009 19:06:21 +0000 (+0200)
Subject: Better handling of the arguments for $tile->set_modified_time()
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=efc0466e8476d3ff0d760505ee422f1489a091fa;p=libchamplain

Better handling of the arguments for $tile->set_modified_time()

The method can now be invoked without arguments and will default to set the
current time.
---

diff --git a/bindings/perl/Champlain/xs/ChamplainTile.xs b/bindings/perl/Champlain/xs/ChamplainTile.xs
index 1591eaf..924193e 100644
--- a/bindings/perl/Champlain/xs/ChamplainTile.xs
+++ b/bindings/perl/Champlain/xs/ChamplainTile.xs
@@ -111,11 +111,9 @@ champlain_tile_get_modified_time_string (ChamplainTile *self)
 		string = champlain_tile_get_modified_time_string(self);
 		if (string) {
 			RETVAL = newSVpvn(string, 0);
-			g_print("--time : %s\n", string);
 			g_free(string);
 		}
 		else {
-			g_print("--Undef time\n");
 			RETVAL = &PL_sv_undef;
 		}
 
@@ -133,17 +131,33 @@ champlain_tile_set_etag (ChamplainTile *self, const gchar *etag)
 
 
 void
-champlain_tile_set_modified_time (ChamplainTile *self, guint seconds = 0, guint microseconds = 0)
+champlain_tile_set_modified_time (ChamplainTile *self, ...)
 	PREINIT:
 		GTimeVal modified_time = {0, };
 
 	CODE:
-		if (microseconds || seconds) {
-			modified_time.tv_sec = seconds;
-			modified_time.tv_usec = microseconds;
+
+		if (items == 1) {
+			/* Use the current time */
+			g_get_current_time(&modified_time);
+		}
+		else if (items == 3) {
+			SV *sv_seconds = ST(1);
+			SV *sv_microseconds = ST(2);
+
+			if (! (sv_seconds && SvOK(sv_seconds))) {
+				croak("$tile->set_modified_time() called with invalid seconds");
+			}
+
+			if (! (sv_microseconds && SvOK(sv_microseconds))) {
+				croak("$tile->set_modified_time() called with invalid microseconds");
+			}
+
+			modified_time.tv_sec = SvIV(sv_seconds);
+			modified_time.tv_usec = SvIV(sv_microseconds);
 		}
 		else {
-			g_get_current_time(&modified_time);
+			croak("Usage: $tile->set_modified_time() or $tile->set_modified_time($seconds, $microseconds)");
 		}
 
 		champlain_tile_set_modified_time(self, &modified_time);