From: wolfgang <wolfgang@d1b88da0-ebda-0310-925b-ed51d893ca5b>
Date: Fri, 13 Jul 2007 14:03:26 +0000 (+0000)
Subject: git-svn-id: http://svn.opengroupware.org/SOGo/inverse/trunk@1106 d1b88da0-ebda-0310... 
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=edbcc55dd6be850bf4e7dbc2218af0e8676729a3;p=scalable-opengroupware.org

git-svn-id: http://svn.opengroupware.org/SOGo/inverse/trunk@1106 d1b88da0-ebda-0310-925b-ed51d893ca5b
---

diff --git a/ChangeLog b/ChangeLog
index 2b35e808..cfc4cf35 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,16 @@
+2007-07-13  Wolfgang Sourdeau  <wsourdeau@inverse.ca>
+
+	* SoObjects/SOGo/SOGoUser.m ([SOGoUser +initialize]): set
+	acceptAnyUser to YES only when the SOGoAuthentificationMethod user
+	default is set to "bypass".
+
+	* SoObjects/SOGo/SOGoAuthenticator.m ([SOGoAuthenticator
+	-checkLogin:_loginpassword:_pwd]): accepts unverified connections
+	when authMethod is set to "bypass" from now on. This would avoid a
+	security concern with a default installation of SOGo.
+	AuthentificationMethod is now prefixed with "SOGo" for better
+	clarity.
+
 2007-07-11  Wolfgang Sourdeau  <wsourdeau@inverse.ca>
 
 	* UI/MailerUI/UIxMailFolderActions.m ([UIxMailFolderActions
diff --git a/SoObjects/SOGo/SOGoAuthenticator.m b/SoObjects/SOGo/SOGoAuthenticator.m
index edf368fb..20856a41 100644
--- a/SoObjects/SOGo/SOGoAuthenticator.m
+++ b/SoObjects/SOGo/SOGoAuthenticator.m
@@ -50,7 +50,7 @@
   if ((self = [super init]))
     {
       authMethod = [[NSUserDefaults standardUserDefaults]
-		     stringForKey: @"AuthentificationMethod"];
+		     stringForKey: @"SOGoAuthentificationMethod"];
       [authMethod retain];
     }
 
@@ -75,7 +75,8 @@
       accept = [um checkLogin: _login andPassword: _pwd];
     }
   else
-    accept = ([_login length] > 0);
+    accept = ([authMethod isEqualToString: @"bypass"]
+	      && [_login length] > 0);
 
   return accept;
 // 	  || ([_login isEqualToString: @"freebusy"]
diff --git a/SoObjects/SOGo/SOGoUser.m b/SoObjects/SOGo/SOGoUser.m
index 17f20876..00d9b3f3 100644
--- a/SoObjects/SOGo/SOGoUser.m
+++ b/SoObjects/SOGo/SOGoUser.m
@@ -92,7 +92,8 @@ NSString *SOGoWeekStartFirstFullWeek = @"FirstFullWeek";
 	ASSIGN (superUsername, nsUsername);
     }
 
-  acceptAnyUser = (![ud stringForKey: @"AuthentificationMethod"]);
+  acceptAnyUser = ([[ud stringForKey: @"SOGoAuthentificationMethod"]
+		     isEqualToString: @"bypass"]);
 }
 
 + (SOGoUser *) userWithLogin: (NSString *) newLogin