From: Thomas Graf <tgraf@suug.ch>
Date: Sun, 9 Jul 2006 18:36:23 +0000 (-0700)
Subject: [PKT_SCHED]: act_api: Fix module leak while flushing actions
X-Git-Tag: v2.6.18-rc2~254^2~2
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ebbaeab18b1c520054ea70e512ac0db7456ede01;p=linux-2.6

[PKT_SCHED]: act_api: Fix module leak while flushing actions

Module reference needs to be given back if message header
construction fails.

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/sched/act_api.c b/net/sched/act_api.c
index 599423cc9d..0972247a83 100644
--- a/net/sched/act_api.c
+++ b/net/sched/act_api.c
@@ -602,8 +602,8 @@ static int tca_action_flush(struct rtattr *rta, struct nlmsghdr *n, u32 pid)
 	return err;
 
 rtattr_failure:
-	module_put(a->ops->owner);
 nlmsg_failure:
+	module_put(a->ops->owner);
 err_out:
 	kfree_skb(skb);
 	kfree(a);