From: Krzysztof Helt <krzysztof.h1@wp.pl>
Date: Fri, 6 Jun 2008 05:45:56 +0000 (-0700)
Subject: modedb: fix incorrect sync and vmode flags for CVT modes
X-Git-Tag: v2.6.26-rc6~87
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e2d4ecafd24d6eee4ae6bdbede0cfd0e78423a33;p=linux-2.6

modedb: fix incorrect sync and vmode flags for CVT modes

The temporary structure for calculated CVT mode is not initialized.  Few
fields have only bits or-ed or and-ed so they may be left in incorrect
(random) state.

Testing of the tridentfb seems like a good exercise for the fbdev layer.

Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---

diff --git a/drivers/video/modedb.c b/drivers/video/modedb.c
index 4735621915..d1bbef930d 100644
--- a/drivers/video/modedb.c
+++ b/drivers/video/modedb.c
@@ -590,6 +590,7 @@ done:
 		    "", (margins) ? " with margins" : "", (interlace) ?
 		    " interlaced" : "");
 
+	    memset(&cvt_mode, 0, sizeof(cvt_mode));
 	    cvt_mode.xres = xres;
 	    cvt_mode.yres = yres;
 	    cvt_mode.refresh = (refresh) ? refresh : 60;