From: David Woodhouse Date: Mon, 21 May 2007 23:53:35 +0000 (-0400) Subject: Make 'headerscheck' stop immediately on an error X-Git-Tag: v2.6.22-rc3~103 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=df5f6311f171cc249e39ccd06321b68823ac68f0;p=linux-2.6 Make 'headerscheck' stop immediately on an error This should make it stop immediately after printing the _helpful_ error message, rather than continuing to spit out many pages more of 'CHECK include/linux/foo.h' before eventually coming to a halt with something less obvious. Now I get this... CHECK include/linux/smb_fs.h /shiny/git/linux-2.6/usr/include/linux/smb_fs.h requires linux/jiffies.h, which does not exist in exported headers make[2]: *** [/shiny/git/linux-2.6/usr/include/linux/.check.smb_fs.h] Error 1 make[1]: *** [linux] Error 2 make: *** [headers_check] Error 2 Signed-off-by-if-Sam-says-so: David Woodhouse [ Sam had better say so! This made me waste way too much time. - Linus] Signed-off-by: Linus Torvalds --- diff --git a/scripts/Makefile.headersinst b/scripts/Makefile.headersinst index f7b6705fd6..8cd63014a0 100644 --- a/scripts/Makefile.headersinst +++ b/scripts/Makefile.headersinst @@ -144,7 +144,7 @@ $(check-y) : $(INSTALL_HDR_PATH)/$(_dst)/.check.%.h : $(INSTALL_HDR_PATH)/$(_dst $(call cmd,check) # Other dependencies for $(check-y) --include /dev/null $(check-y) +include /dev/null $(wildcard $(check-y)) # ... but leave $(check-y) as .PHONY for now until those deps are actually correct. .PHONY: $(check-y)