From: Krzysztof Helt Date: Tue, 16 Oct 2007 08:29:27 +0000 (-0700) Subject: pm3fb: replace busy waiting with cpu_relax X-Git-Tag: v2.6.24-rc1~885 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=deea62d3796da4c53614638ced8d9784dd5b8b41;p=linux-2.6 pm3fb: replace busy waiting with cpu_relax This patch replaces busy waiting with the cpu_relax() call. This makes scrolling faster. Signed-off-by: Krzysztof Helt Signed-off-by: Antonino Daplas Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/drivers/video/pm3fb.c b/drivers/video/pm3fb.c index 6a64b93413..070659992c 100644 --- a/drivers/video/pm3fb.c +++ b/drivers/video/pm3fb.c @@ -110,7 +110,8 @@ static inline void PM3_WRITE_REG(struct pm3_par *par, s32 off, u32 v) static inline void PM3_WAIT(struct pm3_par *par, u32 n) { - while (PM3_READ_REG(par, PM3InFIFOSpace) < n); + while (PM3_READ_REG(par, PM3InFIFOSpace) < n) + cpu_relax(); } static inline void PM3_WRITE_DAC_REG(struct pm3_par *par, unsigned r, u8 v) @@ -209,8 +210,8 @@ static int pm3fb_sync(struct fb_info *info) PM3_WRITE_REG(par, PM3Sync, 0); mb(); do { - while ((PM3_READ_REG(par, PM3OutFIFOWords)) == 0); - rmb(); + while ((PM3_READ_REG(par, PM3OutFIFOWords)) == 0) + cpu_relax(); } while ((PM3_READ_REG(par, PM3OutputFifo)) != PM3Sync_Tag); return 0;