From: Philip Craig Date: Wed, 21 Jun 2006 01:33:26 +0000 (+1000) Subject: [PATCH] 8139cp: fix eeprom read command length X-Git-Tag: v2.6.18-rc1~1081^2~224^2~13 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d73f1e3c3b0703e25728ce5bdda9806d6f2c576f;p=linux-2.6 [PATCH] 8139cp: fix eeprom read command length The read command for the 93C46/93C56 EEPROMS should be 3 bits plus the address. This doesn't appear to affect the operation of the read command, but similar errors for write commands do cause failures. Signed-off-by: Philip Craig Signed-off-by: Jeff Garzik --- diff --git a/drivers/net/8139cp.c b/drivers/net/8139cp.c index 46d8c01437..b49be8f2c1 100644 --- a/drivers/net/8139cp.c +++ b/drivers/net/8139cp.c @@ -1628,7 +1628,7 @@ static int read_eeprom (void __iomem *ioaddr, int location, int addr_len) eeprom_delay (); /* Shift the read command bits out. */ - for (i = 4 + addr_len; i >= 0; i--) { + for (i = 3 + addr_len - 1; i >= 0; i--) { int dataval = (read_cmd & (1 << i)) ? EE_DATA_WRITE : 0; writeb (EE_ENB | dataval, ee_addr); eeprom_delay ();