From: Marcelo Tosatti <mtosatti@redhat.com>
Date: Fri, 25 May 2007 20:28:20 +0000 (-0400)
Subject: [PATCH] libertas: fix oops on rmmod
X-Git-Tag: v2.6.22-rc5~44^2~2^2~29
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d43fb8ee3dab261e475d4f5189cf86182139b7f4;p=linux-2.6

[PATCH] libertas: fix oops on rmmod

Use list_for_each_entry_safe, to protect against list_del().

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---

diff --git a/drivers/net/wireless/libertas/if_usb.c b/drivers/net/wireless/libertas/if_usb.c
index 10698a1c1c..de7a2e2bab 100644
--- a/drivers/net/wireless/libertas/if_usb.c
+++ b/drivers/net/wireless/libertas/if_usb.c
@@ -970,15 +970,12 @@ static int if_usb_init_module(void)
 
 static void if_usb_exit_module(void)
 {
-	struct list_head *ptr;
-	struct usb_card_rec *cardp;
+	struct usb_card_rec *cardp, *cardp_temp;
 
 	lbs_deb_enter(LBS_DEB_MAIN);
 
-	list_for_each(ptr, &usb_devices) {
-		cardp = list_entry(ptr, struct usb_card_rec, list);
+	list_for_each_entry_safe(cardp, cardp_temp, &usb_devices, list)
 		if_usb_reset_device((wlan_private *) cardp->priv);
-	}
 
 	/* API unregisters the driver from USB subsystem */
 	usb_deregister(&if_usb_driver);