From: Kay Sievers Date: Fri, 1 Jun 2007 14:37:43 +0000 (+0200) Subject: fix "do not access parent" warning for ATTR{} X-Git-Tag: 174~1923 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d419e96238f295996f5b8fc1743ab4835f62fcc2;p=systemd fix "do not access parent" warning for ATTR{} --- diff --git a/udev_rules_parse.c b/udev_rules_parse.c index bfbad367..02bddbd0 100644 --- a/udev_rules_parse.c +++ b/udev_rules_parse.c @@ -376,7 +376,7 @@ static int add_to_rules(struct udev_rules *rules, char *line, const char *filena if (strncmp(attr, "device/", 7) == 0) err("the 'device' link is deprecated and will be removed from a future kernel, " "please fix it in %s:%u", filename, lineno); - else if (strchr(attr, '/') != NULL) + else if (strstr(attr, "../") != NULL) err("do not reference parent sysfs directories directly, that may break with a future kernel, " "please fix it in %s:%u", filename, lineno); if (add_rule_key_pair(rule, &rule->attrs, operation, attr, value) != 0)