From: Lennart Poettering <lennart@poettering.net>
Date: Wed, 25 May 2011 16:02:28 +0000 (+0200)
Subject: readahead: explain that it is safe to ignore EACCES
X-Git-Tag: v28~5
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cf37e24688971b29223858f733beb1b85e3af03c;p=systemd

readahead: explain that it is safe to ignore EACCES
---

diff --git a/src/readahead-collect.c b/src/readahead-collect.c
index 913a3400..20881b39 100644
--- a/src/readahead-collect.c
+++ b/src/readahead-collect.c
@@ -380,7 +380,17 @@ static int collect(const char *root) {
 
                 if ((n = read(fanotify_fd, &data, sizeof(data))) < 0) {
 
-                        if (errno == EINTR || errno == EAGAIN || errno == EACCES)
+                        if (errno == EINTR || errno == EAGAIN)
+                                continue;
+
+                        /* fanotify sometimes returns EACCES on read()
+                         * where it shouldn't. For now let's just
+                         * ignore it here (which is safe), but
+                         * eventually this should be
+                         * dropped when the kernel is fixed.
+                         *
+                         * https://bugzilla.redhat.com/show_bug.cgi?id=707577 */
+                        if (errno == EACCES)
                                 continue;
 
                         log_error("Failed to read event: %m");