From: Oleg Nesterov <oleg@tv-sign.ru>
Date: Mon, 26 Jun 2006 07:26:10 +0000 (-0700)
Subject: [PATCH] coredump: copy_process: don't check SIGNAL_GROUP_EXIT
X-Git-Tag: v2.6.18-rc1~734
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cf2dfbfbf4c5cb489ea12defd85a484307b955b8;p=linux-2.6

[PATCH] coredump: copy_process: don't check SIGNAL_GROUP_EXIT

After the previous patch SIGNAL_GROUP_EXIT implies a pending SIGKILL, we
can remove this check from copy_process() because we already checked
!signal_pending().

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---

diff --git a/kernel/fork.c b/kernel/fork.c
index 79e91046f3..9b4e54ef02 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -1156,18 +1156,6 @@ static task_t *copy_process(unsigned long clone_flags,
 	}
 
 	if (clone_flags & CLONE_THREAD) {
-		/*
-		 * Important: if an exit-all has been started then
-		 * do not create this new thread - the whole thread
-		 * group is supposed to exit anyway.
-		 */
-		if (current->signal->flags & SIGNAL_GROUP_EXIT) {
-			spin_unlock(&current->sighand->siglock);
-			write_unlock_irq(&tasklist_lock);
-			retval = -EAGAIN;
-			goto bad_fork_cleanup_namespace;
-		}
-
 		p->group_leader = current->group_leader;
 		list_add_tail_rcu(&p->thread_group, &p->group_leader->thread_group);