From: Stefan Richter <stefanr@s5r6.in-berlin.de>
Date: Thu, 2 Nov 2006 20:16:08 +0000 (+0100)
Subject: ieee1394: sbp2: use list_move_tail()
X-Git-Tag: v2.6.20-rc1~34^2~412^2^2~18
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cd641f68d628e5c44350447d4b8d661991419e60;p=linux-2.6

ieee1394: sbp2: use list_move_tail()

It's OK to reorder list_del() and sbp2util_free_command_dma() here.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---

diff --git a/drivers/ieee1394/sbp2.c b/drivers/ieee1394/sbp2.c
index a7fb588d3c..2b6d9a0fa7 100644
--- a/drivers/ieee1394/sbp2.c
+++ b/drivers/ieee1394/sbp2.c
@@ -619,9 +619,8 @@ static void sbp2util_mark_command_completed(
 		struct sbp2_lu *lu,
 		struct sbp2_command_info *cmd)
 {
-	list_del(&cmd->list);
 	sbp2util_free_command_dma(cmd);
-	list_add_tail(&cmd->list, &lu->cmd_orb_completed);
+	list_move_tail(&cmd->list, &lu->cmd_orb_completed);
 }
 
 /*