From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Sat, 2 Aug 2008 03:30:48 +0000 (+0400)
Subject: [PATCH] proc: inode number fixlet
X-Git-Tag: v2.6.27-rc5~15^2~8
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cc996099174dc05b35b7a29301026987990e7f8c;hp=6450f65168bcf3c03b5fb44c2fe96682c0d3086b;p=linux-2.6

[PATCH] proc: inode number fixlet

Ouch, if number taken from IDA is too big, the intent was to signal an
error, not check for overflow and still do overflowing addition.

One still needs 2^28 proc entries to notice this.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---

diff --git a/fs/proc/generic.c b/fs/proc/generic.c
index 4fb81e9c94..bca0f81eb6 100644
--- a/fs/proc/generic.c
+++ b/fs/proc/generic.c
@@ -330,6 +330,7 @@ retry:
 		spin_lock(&proc_inum_lock);
 		ida_remove(&proc_inum_ida, i);
 		spin_unlock(&proc_inum_lock);
+		return 0;
 	}
 	return PROC_DYNAMIC_FIRST + i;
 }