From: Eric Sesterhenn <snakebyte@gmx.de>
Date: Wed, 22 Mar 2006 23:36:54 +0000 (+0100)
Subject: [PATCH] Bogus NULL pointer check in fs/configfs/dir.c
X-Git-Tag: v2.6.17-rc2~285^2~1
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cbca692c246874a3cc1b5a9b694add4c39e8bc18;p=linux-2.6

[PATCH] Bogus NULL pointer check in fs/configfs/dir.c

We check the "group" pointer after we dereference it.  This check is
bogus, as it cannot be NULL coming in.

Signed-off-by: Joel Becker <joel.becker@oracle.com>
Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>
---

diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c
index 8ed9b06a98..5638c8f936 100644
--- a/fs/configfs/dir.c
+++ b/fs/configfs/dir.c
@@ -504,7 +504,7 @@ static int populate_groups(struct config_group *group)
 	int ret = 0;
 	int i;
 
-	if (group && group->default_groups) {
+	if (group->default_groups) {
 		/* FYI, we're faking mkdir here
 		 * I'm not sure we need this semaphore, as we're called
 		 * from our parent's mkdir.  That holds our parent's