From: Al Viro <viro@zeniv.linux.org.uk>
Date: Sat, 27 May 2006 04:19:54 +0000 (-0400)
Subject: [PATCH] bogus order of copy_from_user() arguments
X-Git-Tag: v2.6.18-rc1~1101^2~6
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c7c0d0a10f6e4cea95ed84adcdd37948cac09b85;p=linux-2.6

[PATCH] bogus order of copy_from_user() arguments

... aka "somebody forgot to swap arguments when converting from copyin()"

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---

diff --git a/drivers/char/rio/rioboot.c b/drivers/char/rio/rioboot.c
index b9abbd0e7e..eca2b95343 100644
--- a/drivers/char/rio/rioboot.c
+++ b/drivers/char/rio/rioboot.c
@@ -280,7 +280,7 @@ int RIOBootCodeHOST(struct rio_info *p, struct DownLoad *rbp)
 			func_exit();
 			return -ENOMEM;
 		}
-		if (copy_from_user(rbp->DataP, DownCode, rbp->Count)) {
+		if (copy_from_user(DownCode, rbp->DataP, rbp->Count)) {
 			kfree(DownCode);
 			p->RIOError.Error = COPYIN_FAILED;
 			func_exit();