From: znek <znek@d1b88da0-ebda-0310-925b-ed51d893ca5b>
Date: Fri, 22 Oct 2004 15:46:56 +0000 (+0000)
Subject: some progress in the mailer
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c3690ab4d4a475d6cd534dff62ca33b75ca7b879;p=scalable-opengroupware.org

some progress in the mailer

git-svn-id: http://svn.opengroupware.org/SOGo/trunk@419 d1b88da0-ebda-0310-925b-ed51d893ca5b
---

diff --git a/SOGo/UI/Mailer/ChangeLog b/SOGo/UI/Mailer/ChangeLog
index 90a66e60..dc17567c 100644
--- a/SOGo/UI/Mailer/ChangeLog
+++ b/SOGo/UI/Mailer/ChangeLog
@@ -1,3 +1,15 @@
+2004-10-22  Marcus Mueller  <znek@mulle-kybernetik.com>
+
+        * v0.9.42
+
+        * UIxMailListView.wox: sorting, proper handling of sort keys.
+          NOTE: there's still an unidentified bug of sort keys failing to be
+          retained on successive paging.
+
+        * UIxMailListView.m: sorting
+
+        * Images/title_*: corrected alpha values
+
 2004-10-20  Marcus Mueller  <znek@mulle-kybernetik.com>
 
         * v0.9.41
diff --git a/SOGo/UI/Mailer/Images/title_attachment_14x14.png b/SOGo/UI/Mailer/Images/title_attachment_14x14.png
index d8af1b02..b9e46675 100644
Binary files a/SOGo/UI/Mailer/Images/title_attachment_14x14.png and b/SOGo/UI/Mailer/Images/title_attachment_14x14.png differ
diff --git a/SOGo/UI/Mailer/Images/title_config.png b/SOGo/UI/Mailer/Images/title_config.png
index 34e76e06..eb5d46fd 100644
Binary files a/SOGo/UI/Mailer/Images/title_config.png and b/SOGo/UI/Mailer/Images/title_config.png differ
diff --git a/SOGo/UI/Mailer/Images/title_junk.png b/SOGo/UI/Mailer/Images/title_junk.png
index b62fec9a..4fdeb5d2 100644
Binary files a/SOGo/UI/Mailer/Images/title_junk.png and b/SOGo/UI/Mailer/Images/title_junk.png differ
diff --git a/SOGo/UI/Mailer/Images/title_read_14x14.png b/SOGo/UI/Mailer/Images/title_read_14x14.png
index 31fc9c3e..1c3e45cf 100644
Binary files a/SOGo/UI/Mailer/Images/title_read_14x14.png and b/SOGo/UI/Mailer/Images/title_read_14x14.png differ
diff --git a/SOGo/UI/Mailer/Images/title_sortdown_12x12.png b/SOGo/UI/Mailer/Images/title_sortdown_12x12.png
index 1a77d1ee..30ff16f8 100644
Binary files a/SOGo/UI/Mailer/Images/title_sortdown_12x12.png and b/SOGo/UI/Mailer/Images/title_sortdown_12x12.png differ
diff --git a/SOGo/UI/Mailer/Images/title_sortup_12x12.png b/SOGo/UI/Mailer/Images/title_sortup_12x12.png
new file mode 100644
index 00000000..404d527d
Binary files /dev/null and b/SOGo/UI/Mailer/Images/title_sortup_12x12.png differ
diff --git a/SOGo/UI/Mailer/Images/title_thread.png b/SOGo/UI/Mailer/Images/title_thread.png
index 8762589e..aed73319 100644
Binary files a/SOGo/UI/Mailer/Images/title_thread.png and b/SOGo/UI/Mailer/Images/title_thread.png differ
diff --git a/SOGo/UI/Mailer/UIxMailListView.m b/SOGo/UI/Mailer/UIxMailListView.m
index c1014889..cc5c9230 100644
--- a/SOGo/UI/Mailer/UIxMailListView.m
+++ b/SOGo/UI/Mailer/UIxMailListView.m
@@ -31,6 +31,12 @@
   id       message;
 }
 
+- (NSString *)defaultSortKey;
+- (NSString *)imap4SortKey;
+- (NSString *)imap4SortOrdering;
+
+- (BOOL)isSortedDescending;
+
 @end
 
 #include "common.h"
@@ -115,13 +121,24 @@ static int attachmentFlagSize = 8096;
   
   sort = [[[self context] request] formValueForKey:@"sort"];
   
-  // TODO: reversed sorts
-  
   if ([sort length] == 0)
     sort = [self defaultSortKey];
   return [sort uppercaseString];
 }
 
+- (BOOL)isSortedDescending {
+  return [[[self context] request] formValueForKey:@"desc"] ? YES : NO;
+}
+
+- (NSString *)imap4SortOrdering {
+  NSString *sort;
+  
+  sort = [self imap4SortKey];
+  if(![self isSortedDescending])
+    return sort;
+  return [@"REVERSE " stringByAppendingString:sort];
+}
+
 - (NSRange)fetchRange {
   if (self->firstMessageNumber == 0)
     return NSMakeRange(0, 50);
@@ -134,7 +151,7 @@ static int attachmentFlagSize = 8096;
   
   self->sortedUIDs 
     = [[[self clientObject] fetchUIDsMatchingQualifier:[self qualifier]
-			    sortOrdering:[self imap4SortKey]] retain];
+			    sortOrdering:[self imap4SortOrdering]] retain];
   return self->sortedUIDs;
 }
 - (unsigned int)totalMessageCount {
diff --git a/SOGo/UI/Mailer/UIxMailListView.wox b/SOGo/UI/Mailer/UIxMailListView.wox
index d33fa476..21456504 100644
--- a/SOGo/UI/Mailer/UIxMailListView.wox
+++ b/SOGo/UI/Mailer/UIxMailListView.wox
@@ -10,7 +10,8 @@
   title="name"
 >
   <div class="titlediv">
-    <a rsrc:href="tbird_073_mailwelcome.png"><var:string label:value="View" />:</a>, <!-- TODO ;-) -->
+    <a rsrc:href="tbird_073_mailwelcome.png"
+    ><var:string label:value="View" />:</a>, <!-- TODO ;-) -->
     <select name="viewfilter">    <!-- var:popup? -->
       <option value="all"   ><var:string label:value="All" /></option>
       <option value="unread"><var:string label:value="Unread" /></option>
@@ -33,32 +34,88 @@
             <var:entity const:name="nbsp" />
           </td>
           <td class="tbtv_headercell" width="50%">
-	    <a href="view" _sort="subject">
+	        <a href="view" _sort="subject">
               <var:string label:value="Subject" />
-              <var:if condition="imap4SortKey" const:value="SUBJECT">
-                <img rsrc:src="title_sortdown_12x12.png" 
-                     class="tbtv_sortcell" />
-              </var:if>
             </a>
+            <var:if condition="imap4SortKey" const:value="SUBJECT">
+              <var:if condition="isSortedDescending" >
+                <a href="view" _sort="subject">
+                  <img rsrc:src="title_sortup_12x12.png"
+                       class="tbtv_sortcell"
+                  />
+                </a>
+              </var:if>
+              <var:if condition="isSortedDescending" const:negate="YES" >
+                <a href="view" _sort="subject" _desc="1">
+                  <img rsrc:src="title_sortdown_12x12.png"
+                       class="tbtv_sortcell"
+                  />
+                </a>
+              </var:if>
+            </var:if>
           </td>
           <td class="tbtv_headercell">
             <var:if condition="showToAddress" const:negate="YES">
-              <a href="view" _sort="from">
+              <a href="view"
+                 _sort="from"
+                 var:queryDictionary="queryParameters"
+              >
                 <var:string label:value="From" />
-                <var:if condition="imap4SortKey" const:value="FROM">
-                  <img rsrc:src="title_sortdown_12x12.png" 
-                       class="tbtv_sortcell" />
-                </var:if>
               </a>
+              <var:if condition="imap4SortKey" const:value="FROM">
+                <var:if condition="isSortedDescending" >
+                  <a href="view"
+                     _sort="from"
+                     var:queryDictionary="queryParameters"
+                  >
+                    <img rsrc:src="title_sortup_12x12.png"
+                         class="tbtv_sortcell"
+                    />
+                  </a>
+                </var:if>
+                <var:if condition="isSortedDescending" const:negate="YES" >
+                  <a href="view"
+                     _sort="from"
+                     _desc="1"
+                     var:queryDictionary="queryParameters"
+                  >
+                    <img rsrc:src="title_sortdown_12x12.png"
+                         class="tbtv_sortcell"
+                    />
+                  </a>
+                </var:if>
+              </var:if>
             </var:if>
             <var:if condition="showToAddress">
-              <a href="view" _sort="to">
+              <a href="view"
+                 _sort="to"
+                 var:queryDictionary="queryParameters"
+              >
                 <var:string label:value="To" />
-                <var:if condition="imap4SortKey" const:value="TO">
-                  <img rsrc:src="title_sortdown_12x12.png"
-                       class="tbtv_sortcell" />
-               </var:if>
               </a>
+              <var:if condition="imap4SortKey" const:value="TO">
+                <var:if condition="isSortedDescending" >
+                  <a href="view"
+                     _sort="to"
+                     var:queryDictionary="queryParameters"
+                  >
+                    <img rsrc:src="title_sortup_12x12.png"
+                         class="tbtv_sortcell"
+                    />
+                  </a>
+                </var:if>
+                <var:if condition="isSortedDescending" const:negate="YES" >
+                  <a href="view"
+                     _sort="to"
+                     _desc="1"
+                     var:queryDictionary="queryParameters"
+                  >
+                    <img rsrc:src="title_sortdown_12x12.png"
+                         class="tbtv_sortcell"
+                    />
+                  </a>
+                </var:if>
+              </var:if>
             </var:if>
           </td>
           <td class="tbtv_headercell" width="17">
@@ -68,13 +125,35 @@
             <img rsrc:src="title_attachment_14x14.png" width="14" height="14" />
           </td>
           <td class="tbtv_headercell">
-            <a href="view" _sort="date">
+            <a href="view"
+               _sort="date"
+               var:queryDictionary="queryParameters"
+            >
               <var:string label:value="Date" />
-              <var:if condition="imap4SortKey" const:value="DATE">
-                <img rsrc:src="title_sortdown_12x12.png"
-                     class="tbtv_sortcell"/>
-              </var:if>
             </a>
+            <var:if condition="imap4SortKey" const:value="DATE">
+              <var:if condition="isSortedDescending" >
+                <a href="view"
+                   _sort="date"
+                   var:queryDictionary="queryParameters"
+                >
+                  <img rsrc:src="title_sortup_12x12.png"
+                       class="tbtv_sortcell"
+                  />
+                </a>
+              </var:if>
+              <var:if condition="isSortedDescending" const:negate="YES" >
+                <a href="view"
+                   _sort="date"
+                   _desc="1"
+                   var:queryDictionary="queryParameters"
+                >
+                  <img rsrc:src="title_sortdown_12x12.png"
+                       class="tbtv_sortcell"
+                  />
+                </a>
+              </var:if>
+            </var:if>
           </td>
         </tr>
         <tr class="tableview">
@@ -88,9 +167,11 @@
               <var:if condition="hasPrevious">
                 <a href="view"
                    _idx="1"
+                   var:queryDictionary="queryParameters"
                 ><var:string label:value="first"/></a> |
                 <a href="view"
                    var:_idx="prevFirstMessageNumber"
+                   var:queryDictionary="queryParameters"
                 ><var:string label:value="previous"/></a> |
               </var:if>
   
@@ -103,6 +184,7 @@
               <var:if condition="hasNext">
                 | <a href="view"
                      var:_idx="nextFirstMessageNumber"
+                     var:queryDictionary="queryParameters"
                   ><var:string label:value="next" /></a>
               </var:if>
             </var:if>
diff --git a/SOGo/UI/Mailer/Version b/SOGo/UI/Mailer/Version
index b64cd580..57c3c0df 100644
--- a/SOGo/UI/Mailer/Version
+++ b/SOGo/UI/Mailer/Version
@@ -1,3 +1,5 @@
 # $Id$
 
-SUBMINOR_VERSION:=41
+SUBMINOR_VERSION:=42
+
+# v0.9.42 requires NGObjWeb v4.3.72
diff --git a/SOGo/UI/Mailer/product.plist b/SOGo/UI/Mailer/product.plist
index 65f9f893..78e48485 100644
--- a/SOGo/UI/Mailer/product.plist
+++ b/SOGo/UI/Mailer/product.plist
@@ -65,7 +65,8 @@
     "title_read_14x14.png",
     "title_thread.png",
     "title_sortdown_12x12.png",
-    
+    "title_sortup_12x12.png",
+
     "tbird_073_accountview.png",
     "tbird_073_compose.png",
     "tbird_073_mailwelcome.png",
diff --git a/SOGo/UI/SOGoUI/ChangeLog b/SOGo/UI/SOGoUI/ChangeLog
index db811fb7..4648fe37 100644
--- a/SOGo/UI/SOGoUI/ChangeLog
+++ b/SOGo/UI/SOGoUI/ChangeLog
@@ -1,3 +1,8 @@
+2004-10-22  Marcus Mueller  <znek@mulle-kybernetik.com>
+
+	* UIxComponent.m: rewrote handling of queryParameters, these get
+	  constructed lazily now (v0.9.17)
+
 2004-10-20  Marcus Mueller  <znek@mulle-kybernetik.com>
 
 	* SOGoJSStringFormatter.[hm]: new formatter to properly escape certain
diff --git a/SOGo/UI/SOGoUI/UIxComponent.m b/SOGo/UI/SOGoUI/UIxComponent.m
index a0634461..51be44ee 100644
--- a/SOGo/UI/SOGoUI/UIxComponent.m
+++ b/SOGo/UI/SOGoUI/UIxComponent.m
@@ -26,6 +26,7 @@
 
 @interface UIxComponent (PrivateAPI)
 - (void)_parseQueryString:(NSString *)_s;
+- (NSMutableDictionary *)_queryParameters;
 @end
 
 @implementation UIxComponent
@@ -98,39 +99,11 @@ static BOOL uixDebugEnabled = NO;
   }
 }
 
-- (id)init {
-  if ((self = [super init])) {
-    self->queryParameters = [[NSMutableDictionary alloc] initWithCapacity:8];
-  }
-  return self;
-}
-
 - (void)dealloc {
   [self->queryParameters release];
   [super dealloc];
 }
 
-/* notifications */
-
-- (void)awake {
-  WORequest *req;
-  NSString  *uri;
-  NSRange   r;
-
-  [super awake];
-
-  req = [[self context] request];
-  uri = [req uri];
-  r   = [uri rangeOfString:@"?"];
-  if (r.length > 0) {
-    NSString *qs;
-    
-    qs = [uri substringFromIndex:(r.location + r.length)];
-    [self->queryParameters removeAllObjects];
-    [self _parseQueryString:qs];
-  }    
-}
-
 /* query parameters */
 
 - (void)_parseQueryString:(NSString *)_s {
@@ -158,7 +131,7 @@ static BOOL uixDebugEnabled = NO;
 }
 
 - (NSString *)queryParameterForKey:(NSString *)_key {
-  return [self->queryParameters objectForKey:_key];
+  return [[self _queryParameters] objectForKey:_key];
 }
 
 - (void)setQueryParameter:(NSString *)_param forKey:(NSString *)_key {
@@ -166,15 +139,36 @@ static BOOL uixDebugEnabled = NO;
     return;
 
   if(_param != nil)
-    [self->queryParameters setObject:_param forKey:_key];
+    [[self _queryParameters] setObject:_param forKey:_key];
   else
-    [self->queryParameters removeObjectForKey:_key];
+    [[self _queryParameters] removeObjectForKey:_key];
 }
 
-- (NSDictionary *)queryParameters {
+- (NSMutableDictionary *)_queryParameters {
+  if(!self->queryParameters) {
+    WORequest *req;
+    NSString  *uri;
+    NSRange   r;
+    
+    self->queryParameters = [[NSMutableDictionary alloc] initWithCapacity:8];
+    
+    req = [[self context] request];
+    uri = [req uri];
+    r   = [uri rangeOfString:@"?" options:NSBackwardsSearch];
+    if (r.length > 0) {
+      NSString *qs;
+      
+      qs = [uri substringFromIndex:NSMaxRange(r)];
+      [self _parseQueryString:qs];
+    }    
+  }
   return self->queryParameters;
 }
 
+- (NSDictionary *)queryParameters {
+  return [self _queryParameters];
+}
+
 - (NSDictionary *)queryParametersBySettingSelectedDate:(NSCalendarDate *)_date{
   NSMutableDictionary *qp;
     
diff --git a/SOGo/UI/SOGoUI/Version b/SOGo/UI/SOGoUI/Version
index 27f42dca..33dfbe1b 100644
--- a/SOGo/UI/SOGoUI/Version
+++ b/SOGo/UI/SOGoUI/Version
@@ -1,3 +1,3 @@
 # $Id$
 
-SUBMINOR_VERSION:=16
+SUBMINOR_VERSION:=17