From: arnd@arndb.de <arnd@arndb.de>
Date: Tue, 2 Dec 2003 08:26:46 +0000 (-0800)
Subject: [PATCH] Build failure - missing linux/limits.h include?
X-Git-Tag: 008~27
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c076a2bde406e617ebfeda6b921d1db89eb1a9f6;p=systemd

[PATCH] Build failure - missing linux/limits.h include?

On Tuesday 25 November 2003 00:12, Chris Larson wrote:
> udev fails to compile here unless I'm doing a KLIBC build.  The reason
> appears to be that the normal limits.h in the gcc inc dir doesn't pull
> in linux/limits.h, whereas the limits.h out in the klibc include dirs
> does.  I'd think it'd be best to add a #include <linux/limits.h> to
> udev.h directly, since it uses PATH_MAX.

No, don't include kernel headers directly if you can avoid it.
The problem you are referring to seems to be with old tool chains,
I have the same symptom with my s390 gcc-2.95/glibc-2.1.3.
Including <sys/param.h> instead of <limits.h> seems to fix it.
---

diff --git a/udev.h b/udev.h
index 89943074..0c1951ad 100644
--- a/udev.h
+++ b/udev.h
@@ -24,7 +24,7 @@
 #define UDEV_H
 
 #include "libsysfs/libsysfs.h"
-#include <limits.h>
+#include <sys/param.h>
 
 #ifdef DEBUG
 #include <syslog.h>