From: Lennart Poettering <lennart@poettering.net>
Date: Thu, 20 Jan 2011 17:44:06 +0000 (+0100)
Subject: service: don't allow reload operations for oneshot services
X-Git-Tag: v17~14
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c06b7a15ea4bd9a6063eb16e1b4ee77ef05714b4;p=systemd

service: don't allow reload operations for oneshot services

During starting of oneshot we are in START state which we don't want to
combine with the RELOAD state, hence we disallow both at the same time.
---

diff --git a/src/service.c b/src/service.c
index 4115e529..03a858a4 100644
--- a/src/service.c
+++ b/src/service.c
@@ -1029,6 +1029,12 @@ static int service_verify(Service *s) {
                 return -EINVAL;
         }
 
+        if (s->type == SERVICE_ONESHOT &&
+            s->exec_command[SERVICE_EXEC_RELOAD]) {
+                log_error("%s has an ExecReload setting, which is not allowed for Type=oneshot services. Refusing.", s->meta.id);
+                return -EINVAL;
+        }
+
         if (s->type == SERVICE_DBUS && !s->bus_name) {
                 log_error("%s is of type D-Bus but no D-Bus service name has been specified. Refusing.", s->meta.id);
                 return -EINVAL;