From: Nathan Lynch Date: Tue, 21 Mar 2006 00:34:45 +0000 (-0600) Subject: [PATCH] powerpc numa: Minor debugging code changes X-Git-Tag: v2.6.17-rc1~1117^2~25 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=bf4b85b0e4bab42b3e8d8b0acc6851bb85e2050b;p=linux-2.6 [PATCH] powerpc numa: Minor debugging code changes Add debug statement for map_cpu_to_node; it's useful for cpu hotplug. Clarify debug statement about not finding the numa reference points property. Don't print a meaningless associativity depth (-1) on non-numa systems. Signed-off-by: Nathan Lynch Signed-off-by: Paul Mackerras --- diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c index dc6392ce25..2ae491d940 100644 --- a/arch/powerpc/mm/numa.c +++ b/arch/powerpc/mm/numa.c @@ -133,6 +133,8 @@ static inline void map_cpu_to_node(int cpu, int node) { numa_cpu_lookup_table[cpu] = node; + dbg("adding cpu %d to node %d\n", cpu, node); + if (!(cpu_isset(cpu, numa_cpumask_lookup_table[node]))) cpu_set(cpu, numa_cpumask_lookup_table[node]); } @@ -246,8 +248,7 @@ static int __init find_min_common_depth(void) if ((len >= 1) && ref_points) { depth = ref_points[1]; } else { - dbg("WARNING: could not find NUMA " - "associativity reference point\n"); + dbg("NUMA: ibm,associativity-reference-points not found.\n"); depth = -1; } of_node_put(rtas_root); @@ -385,10 +386,11 @@ static int __init parse_numa_properties(void) min_common_depth = find_min_common_depth(); - dbg("NUMA associativity depth for CPU/Memory: %d\n", min_common_depth); if (min_common_depth < 0) return min_common_depth; + dbg("NUMA associativity depth for CPU/Memory: %d\n", min_common_depth); + /* * Even though we connect cpus to numa domains later in SMP init, * we need to know the maximum node id now. This is because each