From: Stefan Richter Date: Thu, 25 Jan 2007 21:35:47 +0000 (+0100) Subject: ieee1394: sbp2: lower block queue alignment requirement X-Git-Tag: v2.6.21-rc1~76^2~7 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=beb2fdcad14af14fa38d5098003bd0f53e1c1185;p=linux-2.6 ieee1394: sbp2: lower block queue alignment requirement The old setting is copy & waste from usb-storage and doesn't apply to sbp2. There is only 4-byte alignment required for everything, except for S/G table elements which have to be 8-byte aligned according to the SBP-2 spec. (They happen to be ____cacheline_aligned in our implementation. Whether that's good is another question.) We now simply don't tune block queue alignment at all. The default alignment would surely never become anything else than a multiple of 4, else tons of calls to blk_queue_dma_alignment would have to be added everywhere in drivers/... Signed-off-by: Stefan Richter --- diff --git a/drivers/ieee1394/sbp2.c b/drivers/ieee1394/sbp2.c index 36d7b06932..4edfff46b1 100644 --- a/drivers/ieee1394/sbp2.c +++ b/drivers/ieee1394/sbp2.c @@ -51,7 +51,6 @@ * Grep for inline FIXME comments below. */ -#include #include #include #include @@ -2012,7 +2011,6 @@ static int sbp2scsi_slave_configure(struct scsi_device *sdev) { struct sbp2_lu *lu = (struct sbp2_lu *)sdev->host->hostdata[0]; - blk_queue_dma_alignment(sdev->request_queue, (512 - 1)); sdev->use_10_for_rw = 1; if (sdev->type == TYPE_ROM)