From: Benjamin Herrenschmidt Date: Wed, 31 Oct 2007 03:40:45 +0000 (-0700) Subject: [COMPAT]: Fix new dev_ifname32 returning -EFAULT X-Git-Tag: v2.6.24-rc2~69^2~4 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=be48be08a829db09a4f786f44a1872ef0f533c85;p=linux-2.6 [COMPAT]: Fix new dev_ifname32 returning -EFAULT A stray semicolon slipped in the patch that updated dev_ifname32 to not be inline, causing it to always return -EFAULT. This fixes it. Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David S. Miller --- diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c index a4284ccac1..bd26e4cbb9 100644 --- a/fs/compat_ioctl.c +++ b/fs/compat_ioctl.c @@ -322,7 +322,7 @@ static int dev_ifname32(unsigned int fd, unsigned int cmd, unsigned long arg) int err; uifr = compat_alloc_user_space(sizeof(struct ifreq)); - if (copy_in_user(uifr, compat_ptr(arg), sizeof(struct ifreq32))); + if (copy_in_user(uifr, compat_ptr(arg), sizeof(struct ifreq32))) return -EFAULT; err = sys_ioctl(fd, SIOCGIFNAME, (unsigned long)uifr);